Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752697AbdLKKEH (ORCPT ); Mon, 11 Dec 2017 05:04:07 -0500 Received: from mail-qt0-f195.google.com ([209.85.216.195]:41782 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752376AbdLKKED (ORCPT ); Mon, 11 Dec 2017 05:04:03 -0500 X-Google-Smtp-Source: AGs4zMYSaedAm93hxFEch762zvZ9kl3ASf43EFxyGGXdI35ICkSbF0wYudCg2QB8Q3hPlUeGwxXhYg== Date: Mon, 11 Dec 2017 11:04:00 +0100 From: Thierry Reding To: Dmitry Osipenko Cc: Felipe Balbi , Alan Stern , Greg Kroah-Hartman , Jonathan Hunter , Peter Chen , linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/2] usb: chipidea: tegra: Select Tegra's PHY in Kconfig Message-ID: <20171211100400.GE10671@ulmo> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="a1QUDc0q7S3U7/Jg" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1944 Lines: 54 --a1QUDc0q7S3U7/Jg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 11, 2017 at 02:10:00AM +0300, Dmitry Osipenko wrote: > UDC driver won't probe without Tegra's PHY, hence select it in the > Kconfig. >=20 > Signed-off-by: Dmitry Osipenko > --- > drivers/usb/chipidea/Kconfig | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/usb/chipidea/Kconfig b/drivers/usb/chipidea/Kconfig > index 785f0ed037f7..2ef3b27ea72b 100644 > --- a/drivers/usb/chipidea/Kconfig > +++ b/drivers/usb/chipidea/Kconfig > @@ -27,6 +27,7 @@ config USB_CHIPIDEA_PCI > config USB_CHIPIDEA_UDC > bool "ChipIdea device controller" > depends on USB_GADGET > + select USB_TEGRA_PHY if ARCH_TEGRA This is kind of pointless given that USB_TEGRA_PHY originally was automatically enabled if ARCH_TEGRA was enabled. What do we gain by these two patches, other than maybe make the driver buildable as a module? Thierry --a1QUDc0q7S3U7/Jg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlouWBAACgkQ3SOs138+ s6Fmag/+KXeUWColoRE9PIwR/KKMmjhx/WZDiGTzDXP/D3TbZcUxRKJKzAoR2jd3 jbEDHlJNCnPfu0xOElBzooO+H5bMELiECKns6OVcQXTKkdk8AIhUlULJxb49nvFO bQxW5ztSUu4HlWD2DQqql8yavlYnOJUHKOhhXISkJvbgQiJ1YoxbYMxiKTAIU7tW sJgcE1foIfDXcj1WSfdO4U7rKUvxA9PsamPpyKGBIk7byKiayT/0uAF4fWzBItee uTLIPBr4EFLJPXjpROz6Wb7D0gFR5ldyekDigIqVHV1WF/QVvIUM5elAi5K4NIY5 X1eJNJMg08oFz3TR+zeSJU8cqPPKCA9rfuUnZo/09EjQiFumAZ+e/eXKX7prSNVW qK+V/MpKLO2UsICOIdXynTPi8m2uCxoJIZary1f0R+qA6R610kVXwzLI+Pz7DfGU J197dK7ZP7AVlaKipxXJRy79eva2GkkD7vMaJ+ulRGFM+gBHXkGvfV3zVcsAWXmL 4XMWYB8ZFRCifxHQZVaVIxfEsiqsJ3jsYCd0n03W3wNnqOullqVNzI5V18mjvHbr Dz2ScOa8Vq1/4pmTp+GnWcsEAceUbzTbOXsa78JWF0FUeR78I7k/6B7RvdKFKeH7 /9ATqpPbYl2QWeaZB4yryAiMlGDwU2bHm0gFGyTQHQKMj2PEOKA= =Cs+u -----END PGP SIGNATURE----- --a1QUDc0q7S3U7/Jg--