Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752742AbdLKKWx (ORCPT <rfc822;w@1wt.eu>);
        Mon, 11 Dec 2017 05:22:53 -0500
Received: from mx08-00178001.pphosted.com ([91.207.212.93]:38333 "EHLO
        mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1752048AbdLKKWq (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 11 Dec 2017 05:22:46 -0500
Subject: Re: [PATCH] ARM: debug: add stm32 low-level debug support
To: Philippe Ombredanne <pombredanne@nexb.com>
CC: Alexandre Torgue <alexandre.torgue@st.com>,
        Russell King <linux@armlinux.org.uk>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Gerald Baeza <gerald.baeza@st.com>
References: <1512394376-25962-1-git-send-email-ludovic.Barre@st.com>
 <edcc6666-31eb-5404-0a3e-fa6051707408@st.com>
 <CAOFm3uHzot+BAxKr2o72bc3jknZ_buxU=iG08QTLvG60yUzTWg@mail.gmail.com>
From: Ludovic BARRE <ludovic.barre@st.com>
Message-ID: <fd856ee5-9421-a832-85fe-8b4af604fbbf@st.com>
Date: Mon, 11 Dec 2017 11:22:07 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <CAOFm3uHzot+BAxKr2o72bc3jknZ_buxU=iG08QTLvG60yUzTWg@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.75.127.50]
X-ClientProxiedBy: SFHDAG3NODE2.st.com (10.75.127.8) To GPXDAG6NODE4.st.com
 (10.75.127.80)
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-11_04:,,
 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1142
Lines: 45

Hi Neil, Philippe

thanks for review

I will send V2 with:
-my "signed-off"
-Acked-by: Alexandre TORGUE <alexandre.torgue@st.com>
-SPDX license
/* SPDX-License-Identifier: GPL-2.0 */

BR
Ludo

On 12/11/2017 10:33 AM, Philippe Ombredanne wrote:
> Ludovic,
> 
> On Mon, Dec 11, 2017 at 10:08 AM, Alexandre Torgue
> <alexandre.torgue@st.com> wrote:
>> Hi Ludovic
>>
>> On 12/04/2017 02:32 PM, Ludovic Barre wrote:
>>>
>>> From: Ludovic Barre <ludovic.barre@st.com>
>>>
>>> This adds low-level debug support on USART1 for STM32F4
>>> and STM32F7. Compiled via 'CONFIG_DEBUG_LL' and 'CONFIG_EARLY_PRINTK'.
>>> Enabled via 'earlyprintk' in bootargs.
>>>
>>> Signed-off-by: Gerald Baeza <gerald.baeza@st.com>
>>
>>
>> Acked-by: Alexandre TORGUE <alexandre.torgue@st.com>
> 
> [...]
> 
>>> --- /dev/null
>>> +++ b/arch/arm/include/debug/stm32.S
>>> @@ -0,0 +1,41 @@
>>> +/*
>>> + * Copyright (C) 2017, STMicroelectronics - All Rights Reserved
>>> + * Author: Gerald Baeza <gerald_baeza@st.com>
>>> + * License terms:  GNU General Public License (GPL), version 2
> 
> Have you considered using the new SPDX ids? See THomas doc patches for details.
>