Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751999AbdLKMz6 convert rfc822-to-8bit (ORCPT ); Mon, 11 Dec 2017 07:55:58 -0500 Received: from smtp-out4.electric.net ([192.162.216.195]:53751 "EHLO smtp-out4.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752733AbdLKMz4 (ORCPT ); Mon, 11 Dec 2017 07:55:56 -0500 From: David Laight To: "'Sergey Senozhatsky'" , Andrew Morton , Russell King , "Catalin Marinas" , Mark Salter , "Tony Luck" , David Howells , "Yoshinori Sato" , Guan Xuetao , Borislav Petkov , Greg Kroah-Hartman , Thomas Gleixner , "Peter Zijlstra" , Vineet Gupta , Fengguang Wu CC: Steven Rostedt , Petr Mladek , LKML , "linux-arm-kernel@lists.infradead.org" , "linux-c6x-dev@linux-c6x.org" , "linux-ia64@vger.kernel.org" , "linux-am33-list@redhat.com" , "linux-sh@vger.kernel.org" , "linux-edac@vger.kernel.org" , "x86@kernel.org" , "linux-snps-arc@lists.infradead.org" , Sergey Senozhatsky Subject: RE: [PATCH 11/13] irq debug: do not use print_symbol() Thread-Topic: [PATCH 11/13] irq debug: do not use print_symbol() Thread-Index: AQHTcn8M0eu2cT73bEmc8QJIJX8zNKM+GVLQ Date: Mon, 11 Dec 2017 12:55:49 +0000 Message-ID: <063a776096964e8192c94e38413edbe0@AcuMS.aculab.com> References: <20171211125025.2270-1-sergey.senozhatsky@gmail.com> <20171211125025.2270-12-sergey.senozhatsky@gmail.com> In-Reply-To: <20171211125025.2270-12-sergey.senozhatsky@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.33] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Outbound-IP: 156.67.243.126 X-Env-From: David.Laight@ACULAB.COM X-Proto: esmtps X-Revdns: X-HELO: AcuMS.aculab.com X-TLS: TLSv1.2:ECDHE-RSA-AES256-SHA384:256 X-Authenticated_ID: X-PolicySMART: 3396946, 3397078 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1170 Lines: 33 From: Sergey Senozhatsky > Sent: 11 December 2017 12:50 > print_symbol() uses extra stack space to sprintf() symbol > information and then to feed that buffer to printk() > > char buffer[KSYM_SYMBOL_LEN]; > > sprint_symbol(buffer, address); > printk(fmt, buffer); > > Replace print_symbol() with a direct printk("%pS") call. > > Signed-off-by: Sergey Senozhatsky > Cc: Thomas Gleixner > --- > kernel/irq/debug.h | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/kernel/irq/debug.h b/kernel/irq/debug.h > index 17f05ef8f575..5766e15c1160 100644 > --- a/kernel/irq/debug.h > +++ b/kernel/irq/debug.h ... > @@ -15,13 +13,13 @@ static inline void print_irq_desc(unsigned int irq, struct irq_desc *desc) > printk("irq %d, desc: %p, depth: %d, count: %d, unhandled: %d\n", > irq, desc, desc->depth, desc->irq_count, desc->irqs_unhandled); > printk("->handle_irq(): %p, ", desc->handle_irq); > - print_symbol("%s\n", (unsigned long)desc->handle_irq); > + pr_cont("%pS\n", desc->handle_irq); Looks like you can (and should) use a single printk() instead of pr_cont. David