Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752855AbdLKNJv (ORCPT ); Mon, 11 Dec 2017 08:09:51 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:37472 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751400AbdLKNJr (ORCPT ); Mon, 11 Dec 2017 08:09:47 -0500 X-Google-Smtp-Source: ACJfBosFwaeSDHLSHL89UMJzarghbr+bsfq6m6f+xZ/IyW8oxNoWxfXZfSEx6e88CzUGEqOvJy9TEg== Subject: Re: [PATCH v1 2/2] usb: chipidea: tegra: Select Tegra's PHY in Kconfig To: Thierry Reding Cc: Felipe Balbi , Alan Stern , Greg Kroah-Hartman , Jonathan Hunter , Peter Chen , linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171211100400.GE10671@ulmo> From: Dmitry Osipenko Message-ID: <6dddb581-e708-b96e-cf56-f3bf106117e2@gmail.com> Date: Mon, 11 Dec 2017 16:09:44 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171211100400.GE10671@ulmo> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1270 Lines: 33 On 11.12.2017 13:04, Thierry Reding wrote: > On Mon, Dec 11, 2017 at 02:10:00AM +0300, Dmitry Osipenko wrote: >> UDC driver won't probe without Tegra's PHY, hence select it in the >> Kconfig. >> >> Signed-off-by: Dmitry Osipenko >> --- >> drivers/usb/chipidea/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/usb/chipidea/Kconfig b/drivers/usb/chipidea/Kconfig >> index 785f0ed037f7..2ef3b27ea72b 100644 >> --- a/drivers/usb/chipidea/Kconfig >> +++ b/drivers/usb/chipidea/Kconfig >> @@ -27,6 +27,7 @@ config USB_CHIPIDEA_PCI >> config USB_CHIPIDEA_UDC >> bool "ChipIdea device controller" >> depends on USB_GADGET >> + select USB_TEGRA_PHY if ARCH_TEGRA > > This is kind of pointless given that USB_TEGRA_PHY originally was > automatically enabled if ARCH_TEGRA was enabled. Again, please take a closer look at the patches. USB_TEGRA_PHY was enabled if USB_EHCI_TEGRA was and not ARCH_TEGRA. > What do we gain by these two patches, other than maybe make the driver > buildable as a module? Firstly, tegra-phy is built only if ehci-tegra is built. Secondly, I think we need to enforce Tegra PHY to be compiled as built-in if one of ehci-tegra or chipidea drivers is built-in and the other is compiled as a module.