Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753253AbdLKOIW (ORCPT ); Mon, 11 Dec 2017 09:08:22 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:33655 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752761AbdLKOIU (ORCPT ); Mon, 11 Dec 2017 09:08:20 -0500 X-Google-Smtp-Source: ACJfBosmDmPm0vyCckRIwfSQwtQFxiXTw90wgqNv4f56Ln7ofzp5MepuKdWyMR8La8+11LvGDbDlBA== Subject: Re: [PATCH v1 2/2] drm/tegra: Support disabled CONFIG_PM From: Dmitry Osipenko To: Thierry Reding Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <85902b42264b094cbf7cf30930f8c0bbccdca1b7.1512947732.git.digetx@gmail.com> <02bccd8c39c0e7e9d3c6733e238e291e8297c830.1512947732.git.digetx@gmail.com> <20171211101343.GG10671@ulmo> Message-ID: Date: Mon, 11 Dec 2017 17:08:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1372 Lines: 26 On 11.12.2017 16:53, Dmitry Osipenko wrote: > On 11.12.2017 13:13, Thierry Reding wrote: >> On Mon, Dec 11, 2017 at 02:19:44AM +0300, Dmitry Osipenko wrote: >>> Add manual HW power management to drivers probe/remove in order to >>> not fail in a case of runtime power management being disabled in kernel >>> config. >>> >>> Signed-off-by: Dmitry Osipenko >>> --- >>> drivers/gpu/drm/tegra/dc.c | 164 +++++++++++++++++++++++++++---------------- >>> drivers/gpu/drm/tegra/dsi.c | 138 +++++++++++++++++++++--------------- >>> drivers/gpu/drm/tegra/hdmi.c | 90 ++++++++++++++++-------- >>> drivers/gpu/drm/tegra/sor.c | 103 +++++++++++++++++---------- >>> 4 files changed, 310 insertions(+), 185 deletions(-) >> >> I think that's the wrong way around. We unconditionally select PM on >> 64-bit ARM already, and I think we should do the same on 32-bit ARM. >> There's really no excuse not to enable runtime PM these days. > > What is the rational behind enabling PM unconditionally? It is actually a very > useful debug feature when there is something wrong with the PM. It looks like > Tegra DRM driver is the only driver on Tegra that doesn't work properly with PM > being disabled. Please, let's just fix it. BTW, I've noticed that I sent wrong version of the patch. Will send proper in V2, of course of if you don't mind fixing the driver :)