Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752547AbdLKOcC (ORCPT ); Mon, 11 Dec 2017 09:32:02 -0500 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:7184 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751729AbdLKOcA (ORCPT ); Mon, 11 Dec 2017 09:32:00 -0500 From: Fabien DESSENNE To: Arnd Bergmann , Herbert Xu , "David S. Miller" CC: Maxime Coquelin , Alexandre TORGUE , "linux-crypto@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] crypto: stm32: fix modular build Thread-Topic: [PATCH] crypto: stm32: fix modular build Thread-Index: AQHTcnXttkX2EfBNRUmT5jyWRLUSXKM+I6+A Date: Mon, 11 Dec 2017 14:31:09 +0000 Message-ID: References: <20171211114752.3637710-1-arnd@arndb.de> In-Reply-To: <20171211114752.3637710-1-arnd@arndb.de> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.119] Content-Type: text/plain; charset="utf-8" Content-ID: <5A8553FC184C2C4C9F4E30AD8FDDCD61@st.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-11_06:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vBBEW61o029795 Content-Length: 1318 Lines: 38 Hi Arnd, This issue was reported a few days ago, and Herbert applied the patch 2 minutes before you send the mail (see [https://www.mail-archive.com/linux-crypto@vger.kernel.org/msg29762.html]). Anyway, thank you for reporting this. Fabien On 11/12/17 12:47, Arnd Bergmann wrote: > Building the stm32 crypto suport as a loadable module causes a build > failure from a simple typo: > > drivers/crypto/stm32/stm32-cryp.c:1035:25: error: 'sti_dt_ids' undeclared here (not in a function); did you mean 'stm32_dt_ids'? > > This renames the reference to point to the correct symbol. > > Fixes: 9e054ec21ef8 ("crypto: stm32 - Support for STM32 CRYP crypto module") > Signed-off-by: Arnd Bergmann > --- > drivers/crypto/stm32/stm32-cryp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/stm32/stm32-cryp.c b/drivers/crypto/stm32/stm32-cryp.c > index 459755940632..cf1dddbeaa2c 100644 > --- a/drivers/crypto/stm32/stm32-cryp.c > +++ b/drivers/crypto/stm32/stm32-cryp.c > @@ -1032,7 +1032,7 @@ static const struct of_device_id stm32_dt_ids[] = { > { .compatible = "st,stm32f756-cryp", }, > {}, > }; > -MODULE_DEVICE_TABLE(of, sti_dt_ids); > +MODULE_DEVICE_TABLE(of, stm32_dt_ids); > > static int stm32_cryp_probe(struct platform_device *pdev) > {