Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753088AbdLKOf3 (ORCPT ); Mon, 11 Dec 2017 09:35:29 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:34620 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751728AbdLKOfZ (ORCPT ); Mon, 11 Dec 2017 09:35:25 -0500 Date: Mon, 11 Dec 2017 09:35:20 -0500 (EST) Message-Id: <20171211.093520.1509647114338216500.davem@davemloft.net> To: hayashi.kunihiko@socionext.com Cc: netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, yamada.masahiro@socionext.com, masami.hiramatsu@linaro.org, jaswinder.singh@linaro.org Subject: Re: [PATCH net-next v5 2/2] net: ethernet: socionext: add AVE ethernet driver From: David Miller In-Reply-To: <1512979049-15930-3-git-send-email-hayashi.kunihiko@socionext.com> References: <1512979049-15930-1-git-send-email-hayashi.kunihiko@socionext.com> <1512979049-15930-3-git-send-email-hayashi.kunihiko@socionext.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 11 Dec 2017 06:35:25 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 295 Lines: 10 From: Kunihiko Hayashi Date: Mon, 11 Dec 2017 16:57:29 +0900 > +static inline u32 ave_desc_read(struct net_device *ndev, enum desc_id id, > + int entry, int offset) Do not use inline functions in foo.c files, let the compiler decide what to do. Thank you.