Date: Mon, 11 Dec 2017 15:39:11 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Matthew Auld <matthew.auld@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Ville =?iso-8859-1?Q?Syrj=E4l=E4?= 
        <ville.syrjala@linux.intel.com>,
        Chris Wilson <chris@chris-wilson.co.uk>,
        Paulo Zanoni <paulo.r.zanoni@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        "H . Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/8] x86/early-quirks: replace the magical increment
 start values
Message-ID: <20171211143911.qoina6ruyeawyskz@gmail.com>
References: <20171211121427.26205-1-matthew.auld@intel.com>
 <20171211121427.26205-3-matthew.auld@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20171211121427.26205-3-matthew.auld@intel.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1697
Lines: 49


* Matthew Auld <matthew.auld@intel.com> wrote:

> Replace the magical +2, +9 etc. with +MB, which is far easier to read.
> 
> Suggested-by: Ville Syrj?l? <ville.syrjala@linux.intel.com>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Ville Syrj?l? <ville.syrjala@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: x86@kernel.org
> Cc: linux-kernel@vger.kernel.org
> Reviewed-by: Ville Syrj?l? <ville.syrjala@linux.intel.com>
> ---
>  arch/x86/kernel/early-quirks.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> index 6c1624889011..3cbb2c78a9df 100644
> --- a/arch/x86/kernel/early-quirks.c
> +++ b/arch/x86/kernel/early-quirks.c
> @@ -428,9 +428,9 @@ static resource_size_t __init chv_stolen_size(int num, int slot, int func)
>  	if (gms < 0x11)
>  		return gms * MB(32);
>  	else if (gms < 0x17)
> -		return (gms - 0x11 + 2) * MB(4);
> +		return (gms - 0x11) * MB(4) + MB(8);
>  	else
> -		return (gms - 0x17 + 9) * MB(4);
> +		return (gms - 0x17) * MB(4) + MB(36);
>  }
>  
>  static resource_size_t __init gen9_stolen_size(int num, int slot, int func)
> @@ -446,7 +446,7 @@ static resource_size_t __init gen9_stolen_size(int num, int slot, int func)
>  	if (gms < 0xf0)
>  		return gms * MB(32);
>  	else
> -		return (gms - 0xf0 + 1) * MB(4);
> +		return (gms - 0xf0) * MB(4) + MB(4);

Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo