Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752574AbdLKQE6 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 11 Dec 2017 11:04:58 -0500
Received: from lhrrgout.huawei.com ([194.213.3.17]:10140 "EHLO huawei.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1752204AbdLKQEy (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 11 Dec 2017 11:04:54 -0500
From: Salil Mehta <salil.mehta@huawei.com>
To: Philippe Ombredanne <pombredanne@nexb.com>
CC: "David S. Miller" <davem@davemloft.net>,
        "Zhuangyuzeng (Yisen)" <yisen.zhuang@huawei.com>,
        "lipeng (Y)" <lipeng321@huawei.com>,
        "mehta.salil.lnk@gmail.com" <mehta.salil.lnk@gmail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        Linuxarm <linuxarm@huawei.com>
Subject: RE: [PATCH V2 net-next 2/8] net: hns3: Add mailbox support to VF
 driver
Thread-Topic: [PATCH V2 net-next 2/8] net: hns3: Add mailbox support to VF
 driver
Thread-Index: AQHTcGoBBXA0IyAndEeKAYIVBhFEI6M6FGUAgAQ8e2A=
Date: Mon, 11 Dec 2017 16:04:41 +0000
Message-ID: <F4CC6FACFEB3C54C9141D49AD221F7F93BB72023@FRAEML521-MBX.china.huawei.com>
References: <20171208211702.20104-1-salil.mehta@huawei.com>
 <20171208211702.20104-3-salil.mehta@huawei.com>
 <CAOFm3uH0G7hA0kpiH+SivdLQ6hH_Prq7_gHg6O-hoaO94dPoTQ@mail.gmail.com>
In-Reply-To: <CAOFm3uH0G7hA0kpiH+SivdLQ6hH_Prq7_gHg6O-hoaO94dPoTQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.202.226.117]
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id vBBG51b5001119
Content-Length: 1939
Lines: 61

Hi Philippe,

> -----Original Message-----
> From: Philippe Ombredanne [mailto:pombredanne@nexb.com]
> Sent: Saturday, December 09, 2017 12:17 AM
> To: Salil Mehta <salil.mehta@huawei.com>
> Cc: David S. Miller <davem@davemloft.net>; Zhuangyuzeng (Yisen)
> <yisen.zhuang@huawei.com>; lipeng (Y) <lipeng321@huawei.com>;
> mehta.salil.lnk@gmail.com; netdev@vger.kernel.org; LKML <linux-
> kernel@vger.kernel.org>; linux-rdma@vger.kernel.org; Linuxarm
> <linuxarm@huawei.com>
> Subject: Re: [PATCH V2 net-next 2/8] net: hns3: Add mailbox support to
> VF driver
> 
> Sali,

Sali ---> Salil

Thanks
> 
> On Fri, Dec 8, 2017 at 10:16 PM, Salil Mehta <salil.mehta@huawei.com>
> wrote:
> > This patch adds the support of the mailbox to the VF driver. The
> > mailbox shall be used as an interface to communicate with the
> > PF driver for various purposes like {set|get} MAC related
> > operations, reset, link status etc. The mailbox supports both
> > synchronous and asynchronous command send to PF driver.
> >
> > Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
> > Signed-off-by: lipeng <lipeng321@huawei.com>
> [...]
> > --- /dev/null
> > +++ b/drivers/net/ethernet/hisilicon/hns3/hclge_mbx.h
> > @@ -0,0 +1,94 @@
> > +/*
> > + * Copyright (c) 2016-2017 Hisilicon Limited.
> > + *
> > + * This program is free software; you can redistribute it and/or
> modify
> > + * it under the terms of the GNU General Public License as published
> by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + */
> 
> Why not use the new SPDX ids?
We can. I will change the headers for files [.c .h Makefile] part of HNS3
VF driver change in next V3 patch submit.

> e.g.
> > +/* SPDX-License-Identifier: GPL-2.0+ */
> > +/* Copyright (c) 2016-2017 Hisilicon Limited. */
> 
> See Linus posts and Thomas doc patches for details.
Sure.

Thanks!
> 
> --
> Cordially
> Philippe Ombredanne