Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752816AbdLKQaI (ORCPT ); Mon, 11 Dec 2017 11:30:08 -0500 Received: from mx2.suse.de ([195.135.220.15]:48671 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751400AbdLKQaF (ORCPT ); Mon, 11 Dec 2017 11:30:05 -0500 Date: Mon, 11 Dec 2017 17:30:03 +0100 Message-ID: From: Takashi Iwai To: Vinod Koul Cc: Greg Kroah-Hartman , LKML , ALSA , Mark , Pierre , patches.audio@intel.com, alan@linux.intel.com, Charles Keepax , Sagar Dharia , srinivas.kandagatla@linaro.org, plai@codeaurora.org, Sudheer Papothi Subject: Re: [PATCH v5 00/15] soundwire: Add a new SoundWire subsystem In-Reply-To: <1512575231-4154-1-git-send-email-vinod.koul@intel.com> References: <1512575231-4154-1-git-send-email-vinod.koul@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2506 Lines: 67 On Wed, 06 Dec 2017 16:46:56 +0100, Vinod Koul wrote: > > This patch series adds a new SoundWire subsystem which implements a > new MIPI bus protocol 'SoundWire'. > > The SoundWire protocol is a robust, scalable, low complexity, low > power, low latency, two-pin (clock and data) multi-drop bus that > allows for the transfer of multiple audio streams and embedded > control/commands. SoundWire provides synchronization capabilities > and supports both PCM and PDM, multichannel data, isochronous and > asynchronous modes. > > This series adds SoundWire Bus, IO transfers, DisCo (Discovery and > Configuration) sysfs interface, regmap and Documentation summary > > This patch series is also available on > git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/soundwire.git topic/patch_v5 > > v4: https://lkml.org/lkml/2017/12/1/205 > v3: https://lkml.org/lkml/2017/11/30/160 > v2: https://lkml.org/lkml/2017/11/10/216 > v1: https://lkml.org/lkml/2017/10/18/1030 > RFC: https://lkml.org/lkml/2016/10/21/395 > > Changes in v5: > - Address comments by Pierre > - add reference to mid.mipi.org in documentation > - add group and master device number and don't use those for enumeration > - fix unused calls in disco code and also remove superfluous initialization > - remove sdw_transfer apis slave arg, make enum values integer and not > bitmaps > - clarify the sdw_program_device_num loop and fix interrupt handling > > Changes in v4: > - Remove text licenses and add SPDX tags only with C99 style comments > - make bus_type code as GPL v2.0 only > > Changes in v3: > - Update the kernel-doc styles and fix included headers for files > - handle dev_pm_domain_attach() for defered probe > - remove OF placeholders > - change regmap license to GPLv2 only > > Changes in v2: > - move documentation into driver-api and do rst conversion > - fix documentation comments > - add SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) to all > source files > - rework the transfer logic and paging logic as commented on v1 > - remove dummy sysfs fns > - registration checks and fixes > - remove slave check for regamp as that turned superfluous > - remove depends SoundWire symbol > - make modalias api arg const > - use bitmap for tracking assigned > - add counter for report present tracking > todo: add the dt-bindings The patch series looks mostly OK, so with some nitpicking I've sent in each reply, feel free to take my ack: Reviewed-by: Takashi Iwai thanks, Takashi