Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753021AbdLKQk3 (ORCPT ); Mon, 11 Dec 2017 11:40:29 -0500 Received: from mga14.intel.com ([192.55.52.115]:38704 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752547AbdLKQk0 (ORCPT ); Mon, 11 Dec 2017 11:40:26 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,392,1508828400"; d="scan'208";a="1858884" Date: Mon, 11 Dec 2017 22:14:08 +0530 From: Vinod Koul To: Takashi Iwai Cc: ALSA , Charles Keepax , Sudheer Papothi , patches.audio@intel.com, Greg Kroah-Hartman , plai@codeaurora.org, LKML , Pierre , Mark , srinivas.kandagatla@linaro.org, Sagar Dharia , alan@linux.intel.com Subject: Re: [alsa-devel] [PATCH v5 03/15] soundwire: Add Master registration Message-ID: <20171211164408.GS18649@localhost> References: <1512575231-4154-1-git-send-email-vinod.koul@intel.com> <1512575231-4154-4-git-send-email-vinod.koul@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 374 Lines: 13 On Mon, Dec 11, 2017 at 05:02:10PM +0100, Takashi Iwai wrote: > On Wed, 06 Dec 2017 16:46:59 +0100, > Vinod Koul wrote: > > > > + /* Set group device numbers and master device number */ > > + set_bit(SDW_GROUP12_DEV_NUM | SDW_GROUP13_DEV_NUM, bus->assigned); > > Is this really correct? Nope, this is supposed to bit number and can't be ORed, will fix thanks -- ~Vinod