Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752615AbdLKRFg (ORCPT ); Mon, 11 Dec 2017 12:05:36 -0500 Received: from mail-qt0-f196.google.com ([209.85.216.196]:42435 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751512AbdLKRFe (ORCPT ); Mon, 11 Dec 2017 12:05:34 -0500 X-Google-Smtp-Source: ACJfBotwrGeBOog+M8M+nXUIUmR7u+0Zdx2PRr77eTPW3PSjyCaq9nzovK3kwpYikrKJb01j+Z8DWDsU/O5vAAL3QPA= MIME-Version: 1.0 In-Reply-To: <20171211170149.GD9454@kroah.com> References: <20171211112806.3415781-1-arnd@arndb.de> <70603a0e-15dd-8970-54c9-4f1ac1d005e2@linux.intel.com> <20171211170149.GD9454@kroah.com> From: Arnd Bergmann Date: Mon, 11 Dec 2017 18:05:33 +0100 X-Google-Sender-Auth: 7KGztUQ4zWONchofuLGHc8KrEc0 Message-ID: Subject: Re: [PATCH] usb: xhci: fix incorrect memset() To: Greg Kroah-Hartman Cc: Mathias Nyman , Mathias Nyman , Lu Baolu , linux-usb@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1301 Lines: 33 On Mon, Dec 11, 2017 at 6:01 PM, Greg Kroah-Hartman wrote: > On Mon, Dec 11, 2017 at 02:59:13PM +0200, Mathias Nyman wrote: >> On 11.12.2017 13:27, Arnd Bergmann wrote: >> > gcc-8 warnings about the new driver using a memset with a bogus length: >> > >> > drivers/usb/host/xhci-dbgcap.c: In function 'xhci_dbc_eps_exit': >> > drivers/usb/host/xhci-dbgcap.c:369:2: error: 'memset' used with length equal to number of elements without multiplication by element size [-Werror=memset-elt-size] >> > >> > It looks like the author meant to use sizeof() rather than ARRAY_SIZE() >> > here, so use that. >> > >> > Fixes: dfba2174dc42 ("usb: xhci: Add DbC support in xHCI driver") >> > Signed-off-by: Arnd Bergmann >> > --- >> >> Another patch to fix the same thing was sent earlier as a follow up to the original series. >> https://marc.info/?l=linux-usb&m=151298133524873&w=2 >> >> But your patch includes the Fixes line with the commit id, which is nice. >> >> Both fix the problem, It doesn't matter for me which one gets applied > > They fix it in different ways, which is correct? Both are correct, 'sizeof(dbc->eps)' is the same as 'sizeof(struct dbc_ep) * ARRAY_SIZE(dbc->eps)'. > And Arnd probably doesn't have the hardware to do so? Right. Arnd