Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752346AbdLKRRn convert rfc822-to-8bit (ORCPT ); Mon, 11 Dec 2017 12:17:43 -0500 Received: from mail-bn3nam01on0128.outbound.protection.outlook.com ([104.47.33.128]:65248 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751512AbdLKRRk (ORCPT ); Mon, 11 Dec 2017 12:17:40 -0500 From: Hartley Sweeten To: Lukasz Majewski , Alexander Sverdlin , Arnd Bergmann , "arndbergmann@gmail.com" CC: Russell King , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Olof Johansson , "Linus Walleij" Subject: RE: [PATCH v4 5/5] ARM: ep93xx: ts72xx: Add support for BK3 board - ts72xx derivative Thread-Topic: [PATCH v4 5/5] ARM: ep93xx: ts72xx: Add support for BK3 board - ts72xx derivative Thread-Index: AQHTajY8lZztAPYXakuz2bIYZ8/OaaM+cakg Date: Mon, 11 Dec 2017 17:17:37 +0000 Message-ID: References: <20171116232239.16823-1-lukma@denx.de> <20171130235140.12243-1-lukma@denx.de> <20171130235140.12243-6-lukma@denx.de> In-Reply-To: <20171130235140.12243-6-lukma@denx.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=HartleyS@visionengravers.com; x-originating-ip: [63.230.248.202] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;SN1PR0101MB1566;6:Pn4pDxVHg4IJtbyhrHM2zpLOkMRR72WrB7mcVyHWTi+JMo7EmkqJIJhDEnnfwB09pl51awVI2L+I59qvPHT862yCp76JyNMP0sNKfuN8GyiyenIuMVABhooVNQqnR4apUNwynFMhzz4zXrANhrfZ+m7xmSbGSWVZTZsvfa6YSexaCsiSwe/yqNx+YuGLtv/3qa/QIekijRdSZze1wKbh3ILBLo92VrZmJ5E8pB6/AmuhK3jkfbPbE0tZAHVve1aiR0fCmd9kD+UT5OHUtePFT7FS4t65O0a2rEHBB/QPQFNtpl81RGowqqHoDs9+fJTlGA5sxUiGccgOu84B2aUgufRgfmX6PrDk4ppm3eE+QFw=;5:VP8v6byDs6BenvHQRqMmrVUNBbOM+PSZqlOErnKPSXhAWtPb8A8P8MLr+xV/bRPA7dD9KbD5W7xHOsydsSIdxtBt7jSeM1kXqBT08ITRLNNrfCGvlcpJrRlusM9CNsFz3U3/aYpuqdpwICWf8SqUl8DoAvOVwZVYjuTVVsNQrxo=;24:RxZ4Xw16uMy5ZfTgvOKEU90x0FaoLSwpiYaqt2FRS7bRf+AAnv+YKCs+s1mEbcv3o5dNk7adPbQF6cu6+bPr44EfndNrDHaKKqRra63r1GQ=;7:oSL8fKQh6yqt+shZS1gPedusVDhd6hPEBRXYImm9NsFYFQsUeX7GZhwg7SogXZYms5HEp87mABjtqtGMY4BnUPNCCXa8nNgKJlX/+hKQDsqusTfc2KxWxSSV0e/oZT39S4j6zCqujPmp4c9KhrUd6jGl+41XfeOq5oTwB5cLjkoxeb+H8KMOxN5A2q0mRCAAgNRlXu09tbUozaOkaNhg2fCST8bs04NYq8MyHjfJOdWEC6caJCEQJG4cY7Jc0ZOB x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 7ee07e59-9699-4ed8-0ef5-08d540bb137c x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4602075)(4603075)(4627115)(201702281549075)(2017052603307);SRVR:SN1PR0101MB1566; x-ms-traffictypediagnostic: SN1PR0101MB1566: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231022)(10201501046)(3002001)(6041248)(2016111802025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123560025)(20161123555025)(20161123558100)(6043046)(6072148)(201708071742011);SRVR:SN1PR0101MB1566;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:SN1PR0101MB1566; x-forefront-prvs: 0518EEFB48 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(376002)(39830400002)(346002)(199004)(24454002)(189003)(80792005)(33656002)(2501003)(74316002)(106356001)(14454004)(8676002)(53546010)(81156014)(316002)(478600001)(105586002)(229853002)(8936002)(6436002)(6506006)(53936002)(4326008)(99286004)(2906002)(81166006)(3280700002)(72206003)(6246003)(39060400002)(77096006)(9686003)(110136005)(2900100001)(54906003)(55016002)(25786009)(66066001)(3660700001)(7696005)(76176011)(68736007)(3846002)(6116002)(86362001)(102836003)(575784001)(2950100002)(97736004)(5660300001)(7736002)(305945005);DIR:OUT;SFP:1102;SCL:1;SRVR:SN1PR0101MB1566;H:SN1PR0101MB1565.prod.exchangelabs.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: visionengravers.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ee07e59-9699-4ed8-0ef5-08d540bb137c X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Dec 2017 17:17:37.0564 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d698601f-af92-4269-8099-fd6f11636477 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0101MB1566 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 869 Lines: 36 On Thursday, November 30, 2017 4:52 PM, Lukasz Majewski wrote: > > The BK3 board is a derivative of the ts72xx reference design. Lukasz, I was just reviewing the other TS-72xx boards and noticed this: > +/* BK3 specific defines */ > +#define BK3_CPLDVER_PHYS_BASE 0x23400000 > +#define BK3_CPLDVER_VIRT_BASE 0xfebfd000 > +#define BK3_CPLDVER_SIZE 0x00001000 > + > +static struct map_desc bk3_io_desc[] __initdata = { > + { > + .virtual = BK3_CPLDVER_VIRT_BASE, > + .pfn = __phys_to_pfn(BK3_CPLDVER_PHYS_BASE), > + .length = BK3_CPLDVER_SIZE, > + .type = MT_DEVICE, > + } > +}; > + This register appears to be common to all the TS-72xx boards. I don't think Arnd has pulled the series yet. Would you mind renaming the defines and rebasing this patch? The BK3 board and other TS-72xx boards can then have a common .map_io. Thanks, Hartley