Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752318AbdLKRfE (ORCPT ); Mon, 11 Dec 2017 12:35:04 -0500 Received: from mail-oi0-f67.google.com ([209.85.218.67]:42387 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750707AbdLKRfB (ORCPT ); Mon, 11 Dec 2017 12:35:01 -0500 X-Google-Smtp-Source: ACJfBov/VzaY28PZHKwIgKo2oORatBk+KmYmx33xy/xLSzjOVL0H9yHu2uUpu0coUV7syITrYNuhtQ== Subject: Re: [PATCH 1/1] rtlwifi: always initialize variables given to RT_TRACE() To: Nicolas Iooss , Chaoming Li , Kalle Valo , linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171210195159.7454-1-nicolas.iooss_linux@m4x.org> From: Larry Finger Message-ID: <20ca7de6-f99e-1c61-4157-c7ab32e85406@lwfinger.net> Date: Mon, 11 Dec 2017 11:34:59 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171210195159.7454-1-nicolas.iooss_linux@m4x.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2419 Lines: 57 On 12/10/2017 01:51 PM, Nicolas Iooss wrote: > In rtl_rx_ampdu_apply(), when rtlpriv->cfg->ops->get_btc_status() > returns false, RT_TRACE() is called with the values of variables > reject_agg and agg_size, which have not been initialized. > > Always initialize these variables in order to prevent using > uninitialized values. > > This issue has been found with clang. The compiler reported: > > drivers/net/wireless/realtek/rtlwifi/base.c:1665:6: error: variable > 'agg_size' is used uninitialized whenever 'if' condition is false > [-Werror,-Wsometimes-uninitialized] > if (rtlpriv->cfg->ops->get_btc_status()) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/net/wireless/realtek/rtlwifi/base.c:1671:31: note: > uninitialized use occurs here > reject_agg, ctrl_agg_size, agg_size); > ^~~~~~~~ > > drivers/net/wireless/realtek/rtlwifi/base.c:1665:6: error: variable > 'reject_agg' is used uninitialized whenever 'if' condition > is false [-Werror,-Wsometimes-uninitialized] > if (rtlpriv->cfg->ops->get_btc_status()) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/net/wireless/realtek/rtlwifi/base.c:1671:4: note: > uninitialized use occurs here > reject_agg, ctrl_agg_size, agg_size); > ^~~~~~~~~~ > > Fixes: 2635664e6e4a ("rtlwifi: Add rx ampdu cfg for btcoexist.") > Signed-off-by: Nicolas Iooss Looks good. Acked-by: Larry Finger Thanks, Larry > --- > drivers/net/wireless/realtek/rtlwifi/base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c > index cad2272ae21b..704741d6f495 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/base.c > +++ b/drivers/net/wireless/realtek/rtlwifi/base.c > @@ -1726,7 +1726,7 @@ int rtl_tx_agg_oper(struct ieee80211_hw *hw, > void rtl_rx_ampdu_apply(struct rtl_priv *rtlpriv) > { > struct rtl_btc_ops *btc_ops = rtlpriv->btcoexist.btc_ops; > - u8 reject_agg, ctrl_agg_size = 0, agg_size; > + u8 reject_agg = 0, ctrl_agg_size = 0, agg_size = 0; > > if (rtlpriv->cfg->ops->get_btc_status()) > btc_ops->btc_get_ampdu_cfg(rtlpriv, &reject_agg, >