Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752291AbdLKUij convert rfc822-to-8bit (ORCPT ); Mon, 11 Dec 2017 15:38:39 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:58980 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751234AbdLKUif (ORCPT ); Mon, 11 Dec 2017 15:38:35 -0500 From: Joseph Salisbury Subject: [REGRESSION][4.13.y][4.14.y][v4.15.y] net: reduce skb_warn_bad_offload() noise To: edumazet@google.com Cc: dvyukov@google.com, willemb@google.com, davem@davemloft.net, daniel@iogearbox.net, jakub.kicinski@netronome.com, linux@rasmusvillemoes.dk, john.fastabend@gmail.com, me@tobin.cc, idosch@mellanox.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, stable@vger.kernel.org, 1715609@bugs.launchpad.net Message-ID: <0a352e7b-0404-2f91-206f-099e2376ab9a@canonical.com> Date: Mon, 11 Dec 2017 15:35:34 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 776 Lines: 28 Hi Eric, A kernel bug report was opened against Ubuntu [0].  It was found that reverting the following commit resolved this bug: commit b2504a5dbef3305ef41988ad270b0e8ec289331c Author: Eric Dumazet Date:   Tue Jan 31 10:20:32 2017 -0800     net: reduce skb_warn_bad_offload() noise     The regression was introduced as of v4.11-rc1 and still exists in current mainline.     I was hoping to get your feedback, since you are the patch author.  Do you think gathering any additional data will help diagnose this issue, or would it be best to submit a revert request?     This commit did in fact resolve another bug[1], but in the process introduced this regression.    Thanks, Joe [0] http://pad.lv/1715609 [1] http://pad.lv/1705447