Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752380AbdLKVGG (ORCPT ); Mon, 11 Dec 2017 16:06:06 -0500 Received: from mga17.intel.com ([192.55.52.151]:58127 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751234AbdLKVF7 (ORCPT ); Mon, 11 Dec 2017 16:05:59 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,392,1508828400"; d="scan'208";a="15143563" X-Mailer: emacs 25.3.1 (via feedmail 11-beta-1 I) From: Flavio Ceolin To: Laurent Pinchart Cc: linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Hans Verkuil , Petr Cvek , Sakari Ailus , Niklas =?utf-8?Q?S=C3=B6derlund?= , Julia Lawall , Arnd Bergmann , "open list\:MEDIA INPUT INFRASTRUCTURE \(V4L\/DVB\)" Subject: Re: [PATCH] media: pxa_camera: disable and unprepare the clock source on error In-Reply-To: <1880720.cnKARQTyeT@avalon> References: <20171206163852.8532-1-flavio.ceolin@intel.com> <1880720.cnKARQTyeT@avalon> Date: Mon, 11 Dec 2017 13:05:46 -0800 Message-ID: <878te9561h.fsf@faceolin-mobl2.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1722 Lines: 58 Hi Laurent, > Hi Flavio, > > Thank you for the patch. > > On Wednesday, 6 December 2017 18:38:50 EET Flavio Ceolin wrote: >> pxa_camera_probe() was not calling pxa_camera_deactivate(), >> responsible to call clk_disable_unprepare(), on the failure path. This >> was leading to unbalancing source clock. >> >> Found by Linux Driver Verification project (linuxtesting.org). > > Any chance I could sign you up for more work on this driver ? :-) Definetely, this would be great :) > >> Signed-off-by: Flavio Ceolin > > Reviewed-by: Laurent Pinchart > > I expect Hans Verkuil to pick up the patch. > >> --- >> drivers/media/platform/pxa_camera.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/media/platform/pxa_camera.c >> b/drivers/media/platform/pxa_camera.c index 9d3f0cb..7877037 100644 >> --- a/drivers/media/platform/pxa_camera.c >> +++ b/drivers/media/platform/pxa_camera.c >> @@ -2489,7 +2489,7 @@ static int pxa_camera_probe(struct platform_device >> *pdev) dev_set_drvdata(&pdev->dev, pcdev); >> err = v4l2_device_register(&pdev->dev, &pcdev->v4l2_dev); >> if (err) >> - goto exit_free_dma; >> + goto exit_deactivate; >> >> pcdev->asds[0] = &pcdev->asd; >> pcdev->notifier.subdevs = pcdev->asds; >> @@ -2525,6 +2525,8 @@ static int pxa_camera_probe(struct platform_device >> *pdev) v4l2_clk_unregister(pcdev->mclk_clk); >> exit_free_v4l2dev: >> v4l2_device_unregister(&pcdev->v4l2_dev); >> +exit_deactivate: >> + pxa_camera_deactivate(pcdev); >> exit_free_dma: >> dma_release_channel(pcdev->dma_chans[2]); >> exit_free_dma_u: > > -- > Regards, > > Laurent Pinchart Regards, Flavio Ceolin