Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752103AbdLKVj6 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 11 Dec 2017 16:39:58 -0500
Received: from mail-out.m-online.net ([212.18.0.9]:41358 "EHLO
        mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751622AbdLKVj5 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 11 Dec 2017 16:39:57 -0500
X-Auth-Info: iBU5c2rlVQXX88flccDWpXJaIZnw6X4MhP4XuD/EU0M=
Date: Mon, 11 Dec 2017 22:39:41 +0100
From: Lukasz Majewski <lukma@denx.de>
To: Hartley Sweeten <HartleyS@visionengravers.com>
Cc: Alexander Sverdlin <alexander.sverdlin@gmail.com>,
        Arnd Bergmann <arnd@arndb.de>,
        "arndbergmann@gmail.com" <arndbergmann@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Olof Johansson <olof@lixom.net>,
        "Linus Walleij" <linus.walleij@linaro.org>
Subject: Re: [PATCH v4 5/5] ARM: ep93xx: ts72xx: Add support for BK3 board -
 ts72xx derivative
Message-ID: <20171211223941.744be82f@jawa>
In-Reply-To: <SN1PR0101MB156532C13ABBAE280B3754CED0370@SN1PR0101MB1565.prod.exchangelabs.com>
References: <20171116232239.16823-1-lukma@denx.de>
        <20171130235140.12243-1-lukma@denx.de>
        <20171130235140.12243-6-lukma@denx.de>
        <SN1PR0101MB156532C13ABBAE280B3754CED0370@SN1PR0101MB1565.prod.exchangelabs.com>
Organization: denx.de
X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 boundary="Sig_/rQXGfNf6X14TlLEIcboCx8c"; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2611
Lines: 94

--Sig_/rQXGfNf6X14TlLEIcboCx8c
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Hartley,

> On Thursday, November 30, 2017 4:52 PM, Lukasz Majewski wrote:
> >
> > The BK3 board is a derivative of the ts72xx reference design. =20
>=20
> Lukasz,
>=20
> I was just reviewing the other TS-72xx boards and noticed this:
>=20
> <snip>
>=20
> > +/* BK3 specific defines */
> > +#define BK3_CPLDVER_PHYS_BASE		0x23400000
> > +#define BK3_CPLDVER_VIRT_BASE		0xfebfd000
> > +#define BK3_CPLDVER_SIZE		0x00001000
> > + =20
>=20
> <snip>
>=20
> > +static struct map_desc bk3_io_desc[] __initdata =3D {
> > +	{
> > +		.virtual	=3D BK3_CPLDVER_VIRT_BASE,
> > +		.pfn		=3D
> > __phys_to_pfn(BK3_CPLDVER_PHYS_BASE),
> > +		.length	=3D BK3_CPLDVER_SIZE,
> > +		.type		=3D MT_DEVICE,
> > +	}
> > +};
> > + =20
>=20
> This register appears to be common to all the TS-72xx boards.

The CPLD was used on the reference ts-72xx boards, but support for it
seems to not be present in the mainline kernel.

Do you have a ts72xx board with CPLD embedded? Is any of your design
using it?


My another concern - is it safe to perform IO mapping on memory regions
which are not used / specified? When I do a single ts72xx mapping - for
all boards - then we may end up with some mappings which are not needed.

With the code as it is - I only map regions which are already used on
relevant boards.

>=20
> I don't think Arnd has pulled the series yet. Would you mind renaming
> the defines and rebasing this patch?=20

If needed I can resend the patch series, or prepare a single fix patch.
No problem.

> The BK3 board and other TS-72xx
> boards can then have a common .map_io.
>=20
> Thanks,
> Hartley
>=20



Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de

--Sig_/rQXGfNf6X14TlLEIcboCx8c
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAlou+x4ACgkQAR8vZIA0
zr3F3wgAr6kMKECH4Z65fcGtt4Qq5QjJ1F5jst1olUm1u9XBDIVmQu/yyNkkj7oY
Ezn4v2Duf1OzyrPmMS8B3swn8akcIj5W1q+8HJqZBQzFaQs+q+8gEBiX8fXzHEzT
wGMg6OFAVbXaEmWu3GhluOcPzztN/sWk0TfUuNCQwRa+RvfdBMA3g4DM96P8j0O6
B1veXpH04axqfgWIN4xCSwqTL7tCxC1cn1CUQ4n1ixUfjRc2praUzgd3zq6KO1s3
AsgBJoH2jMvCTF9P4LFMPIPC9HrBb9w4ht1Ymic/bjlSca3/ub3iC9sfqZNhVEF+
Uv8dl/OPm1tuiZ1m/OriloBQ0ZqsBQ==
=xe47
-----END PGP SIGNATURE-----

--Sig_/rQXGfNf6X14TlLEIcboCx8c--