Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752596AbdLKWXB (ORCPT ); Mon, 11 Dec 2017 17:23:01 -0500 Received: from esa1.hgst.iphmx.com ([68.232.141.245]:40831 "EHLO esa1.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752340AbdLKWW7 (ORCPT ); Mon, 11 Dec 2017 17:22:59 -0500 X-IronPort-AV: E=Sophos;i="5.45,393,1508774400"; d="scan'208";a="167435751" From: Bart Van Assche To: "kartilak@cisco.com" , "linux-scsi@vger.kernel.org" , "nicolas.iooss_linux@m4x.org" , "satishkh@cisco.com" , "sebaddel@cisco.com" CC: "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/1] scsi: fnic: add a space after %p in printf format Thread-Topic: [PATCH 1/1] scsi: fnic: add a space after %p in printf format Thread-Index: AQHTce2e9mY/j8jcpEC4Wpn2PsV/T6M+uUyA Date: Mon, 11 Dec 2017 22:22:55 +0000 Message-ID: <1513030969.2747.19.camel@wdc.com> References: <20171210192311.5334-1-nicolas.iooss_linux@m4x.org> In-Reply-To: <20171210192311.5334-1-nicolas.iooss_linux@m4x.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [199.255.44.171] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BY1PR0401MB1530;20:rVLsG2ywJGiPHehFy9tDM31UGuvOQIsWkca2PODMrYt/bAm/Y4Yu1+alikesPkQuR0i1TrPhDFzuAvrNiCBSJ+O4ib150689vgITCDR7+UV+6xHhtvGT1ICkAsghwxQjrk8ADpUvNC+4rSh0xXc+wOxOV5TumCUjYHSLvdf+qqk= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 4ea56f19-1691-412e-6ea1-08d540e5ba00 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603307);SRVR:BY1PR0401MB1530; x-ms-traffictypediagnostic: BY1PR0401MB1530: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(3231023)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123555025)(20161123558100)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(201708071742011);SRVR:BY1PR0401MB1530;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:BY1PR0401MB1530; x-forefront-prvs: 0518EEFB48 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39860400002)(366004)(376002)(346002)(377424004)(189003)(24454002)(199004)(36756003)(66066001)(7736002)(76176011)(110136005)(105586002)(4001150100001)(2950100002)(81156014)(81166006)(59450400001)(103116003)(2501003)(106356001)(478600001)(3280700002)(229853002)(68736007)(14454004)(6512007)(5660300001)(97736004)(2906002)(102836003)(305945005)(6246003)(6116002)(8936002)(8676002)(2201001)(4326008)(6506006)(6486002)(25786009)(2900100001)(3846002)(3660700001)(72206003)(86362001)(316002)(99286004)(575784001)(53936002)(5250100002)(6436002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR0401MB1530;H:BY1PR0401MB1532.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <6CC72A47AD8C734498F3474227A28905@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ea56f19-1691-412e-6ea1-08d540e5ba00 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Dec 2017 22:22:55.3197 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0401MB1530 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vBBMN7rW020816 Content-Length: 1126 Lines: 32 On Sun, 2017-12-10 at 20:23 +0100, Nicolas Iooss wrote: > fnic_fcpio_icmnd_cmpl_handler() displays the value of sc with: > > FNIC_SCSI_DBG(KERN_INFO... > "... sc = 0x%p" > "scsi_status ..." > ... > > As the literal strings get merged, the function uses %ps instead of the > intended raw %p format. Fix this by inserting a space. > > Signed-off-by: Nicolas Iooss > --- > drivers/scsi/fnic/fnic_scsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c > index 242e2ee494a1..8cbd3c9f0b4c 100644 > --- a/drivers/scsi/fnic/fnic_scsi.c > +++ b/drivers/scsi/fnic/fnic_scsi.c > @@ -906,7 +906,7 @@ static void fnic_fcpio_icmnd_cmpl_handler(struct fnic *fnic, > > FNIC_SCSI_DBG(KERN_INFO, fnic->lport->host, > "icmnd_cmpl abts pending " > - "hdr status = %s tag = 0x%x sc = 0x%p" > + "hdr status = %s tag = 0x%x sc = 0x%p " > "scsi_status = %x residual = %d\n", Since the %p format specifier already inserts a 0x prefix, shouldn't 0x%p be changed into %p? Bart.