Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752274AbdLKXCe (ORCPT ); Mon, 11 Dec 2017 18:02:34 -0500 Received: from opengridcomputing.com ([70.118.0.34]:46778 "EHLO smtp.opengridcomputing.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752204AbdLKXCd (ORCPT ); Mon, 11 Dec 2017 18:02:33 -0500 From: "Steve Wise" To: "'Jason Gunthorpe'" , "'Arnd Bergmann'" Cc: "'Steve Wise'" , "'Doug Ledford'" , "'Bharat Potnuri'" , "'Leon Romanovsky'" , "'Ganesh Goudar'" , , References: <20171127114518.2662754-1-arnd@arndb.de> <20171211225620.GB7551@ziepe.ca> In-Reply-To: <20171211225620.GB7551@ziepe.ca> Subject: RE: [PATCH] infiniband: cxgb4: use ktime_get for timestamps Date: Mon, 11 Dec 2017 17:02:36 -0600 Message-ID: <06fc01d372d4$22bbe9d0$6833bd70$@opengridcomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQIqUjee9r4xpCMNlOKAoCtubUKGMAIp30LNon+zwiA= Content-Language: en-us X-Antivirus: AVG (VPS 171211-6, 12/11/2017), Outbound message X-Antivirus-Status: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1544 Lines: 38 > Subject: Re: [PATCH] infiniband: cxgb4: use ktime_get for timestamps > > On Mon, Nov 27, 2017 at 12:44:53PM +0100, Arnd Bergmann wrote: > > The debugfs file prints the difference between host timestamps as a > > seconds/nanoseconds tuple, along with a 64-bit nanoseconds hardware > > timestamp. The host time is read using getnstimeofday() which is > > deprecated because of the y2038 overflow, and it suffers from time jumps > > during settimeofday() and leap seconds. > > > > Converting to ktime_get_ts64() would solve those two, but I'm going > > a little further here by changing to ktime_get() and printing 64-bit > > nanoseconds on both host and hw timestamps. This simplifies the code > > further and makes the output easier to understand. > > > > The format of the debugfs file obviously changes here, but this should > > only be read by humans and not scripts, so I assume it's fine. > > > > Signed-off-by: Arnd Bergmann > > drivers/infiniband/hw/cxgb4/device.c | 34 +++++++++++++++------------------- > > drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 4 ++-- > > drivers/infiniband/hw/cxgb4/qp.c | 6 +++--- > > drivers/infiniband/hw/cxgb4/t4.h | 4 ++-- > > 4 files changed, 22 insertions(+), 26 deletions(-) > > Steve? This changes the format of the debugfs files, so please ack it > if it is Ok.. > I apologize for missing this patch initially. I think this is fine. Acked-by: Steve Wise --- This email has been checked for viruses by AVG. http://www.avg.com