Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752243AbdLKXej (ORCPT ); Mon, 11 Dec 2017 18:34:39 -0500 Received: from esa5.hgst.iphmx.com ([216.71.153.144]:4217 "EHLO esa5.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750836AbdLKXee (ORCPT ); Mon, 11 Dec 2017 18:34:34 -0500 X-IronPort-AV: E=Sophos;i="5.45,393,1508774400"; d="scan'208";a="64714449" From: Bart Van Assche To: "nicolas.iooss_linux@m4x.org" CC: "kartilak@cisco.com" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "satishkh@cisco.com" , "sebaddel@cisco.com" Subject: Re: [PATCH 1/1] scsi: fnic: add a space after %p in printf format Thread-Topic: [PATCH 1/1] scsi: fnic: add a space after %p in printf format Thread-Index: AQHTce2e9mY/j8jcpEC4Wpn2PsV/T6M+uUyAgAAI8ICAAAsXAA== Date: Mon, 11 Dec 2017 23:34:31 +0000 Message-ID: <1513035270.2747.31.camel@wdc.com> References: <20171210192311.5334-1-nicolas.iooss_linux@m4x.org> <1513030969.2747.19.camel@wdc.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [199.255.44.171] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1533;20:1BlQXlTEyEjOESwbVR/tfILZPPTxDI4cZaUXscQi2rmNtD6Bg+xAtQPuqYtTpL5lEdTCOBh0k9R6FDp/1c1piwcn5wTKYQ5S5zHbiuFhQmG80UljeOHg0uqnX0LBsXbYregDcFsLIrFB9Eqn5Y3pZB4JGCK9+XI5S+ED5SOkUTU= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: a8f73ce3-c28d-49db-64a9-08d540efbb1f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603307);SRVR:CY1PR0401MB1533; x-ms-traffictypediagnostic: CY1PR0401MB1533: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(84791874153150); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(3231023)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041248)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123564025)(6072148)(201708071742011);SRVR:CY1PR0401MB1533;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:CY1PR0401MB1533; x-forefront-prvs: 0518EEFB48 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(979002)(39860400002)(376002)(346002)(366004)(24454002)(199004)(189003)(377424004)(99286004)(102836003)(3660700001)(36756003)(3846002)(8676002)(3280700002)(81156014)(81166006)(6116002)(4326008)(53546010)(106356001)(5640700003)(6506006)(6486002)(77096006)(72206003)(6436002)(305945005)(105586002)(2906002)(7736002)(478600001)(2351001)(229853002)(25786009)(14454004)(103116003)(6246003)(8936002)(76176011)(6916009)(2950100002)(54906003)(66066001)(97736004)(2501003)(86362001)(4001150100001)(68736007)(6512007)(6306002)(316002)(53936002)(5660300001)(2900100001)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1533;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: a8f73ce3-c28d-49db-64a9-08d540efbb1f X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Dec 2017 23:34:32.2301 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1533 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vBBNYk37000907 Content-Length: 778 Lines: 18 On Mon, 2017-12-11 at 23:54 +0100, Nicolas Iooss wrote: > On Mon, Dec 11, 2017 at 11:22 PM, Bart Van Assche > wrote: > > On Sun, 2017-12-10 at 20:23 +0100, Nicolas Iooss wrote: > > > - "hdr status = %s tag = 0x%x sc = 0x%p" > > > + "hdr status = %s tag = 0x%x sc = 0x%p " > > > "scsi_status = %x residual = %d\n", > > > > Since the %p format specifier already inserts a 0x prefix, shouldn't 0x%p be changed > > into %p? > > Does it? On the kernel I use it does not, and the documentation for %p > does not show a 0x prefix > (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/printk-formats.txt?h=v4.15-rc3#n57). Please ignore my comment. Bart.