Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752217AbdLLBqC (ORCPT ); Mon, 11 Dec 2017 20:46:02 -0500 Received: from m12-16.163.com ([220.181.12.16]:49134 "EHLO m12-16.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751234AbdLLBqB (ORCPT ); Mon, 11 Dec 2017 20:46:01 -0500 To: matthew@wil.cx, hare@suse.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, Linux Kernel Mailing List From: Jia-Ju Bai Subject: [BUG] drivers/scsi/advansys: three possible sleep-in-atomic bugs in advansys_interrupt Message-ID: Date: Tue, 12 Dec 2017 09:44:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-CM-TRANSID: EMCowACHgENnNC9a2OpJDQ--.33656S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxUyGXdDUUUU X-Originating-IP: [166.111.70.3] X-CM-SenderInfo: xedlyx5dmximizq6il2tof0z/1tbiTgiselUC1FvEMQAAs9 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 616 Lines: 21 According to drivers/scsi/advansys.c, the kernel module may sleep in the interrupt handler. The function call paths are: advansys_interrupt (interrupt handler) AdvISR adv_async_callback AdvResetChipAndSB AdvInitAsc38C1600Driver request_firmware --> may sleep AdvInitAsc38C0800Driver request_firmware --> may sleep AdvInitAsc3550Driver request_firmware --> may sleep I do not find a good way to fix them, so I only report. These possible bugs are found by my static analysis tool (DSAC) and checked by my code review. Thanks, Jia-Ju Bai