Date: Tue, 12 Dec 2017 11:08:17 +0800
From: Peter Chen <hzpeterchen@gmail.com>
To: Johan Hovold <johan@kernel.org>,
        Stephen Boyd <stephen.boyd@linaro.org>
CC: Peter Chen <Peter.Chen@nxp.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        stable <stable@vger.kernel.org>, Frank Rowand <frank.rowand@sony.com>
Subject: Re: [PATCH] USB: chipidea: msm: fix ulpi-node lookup
Message-ID: <20171212030816.GB22364@b29397-desktop>
References: <20171113101258.3324-1-johan@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20171113101258.3324-1-johan@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2017 03:09:20.9717
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 35e465c8-e2b4-4d0a-c640-08d5410dbd72
X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2697
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1458
Lines: 37

On Mon, Nov 13, 2017 at 11:12:58AM +0100, Johan Hovold wrote:
> Fix child-node lookup during probe, which ended up searching the whole
> device tree depth-first starting at the parent rather than just matching
> on its children.
> 
> Note that the original premature free of the parent node has already
> been fixed separately, but that fix was apparently never backported to
> stable.
> 
> Fixes: 47654a162081 ("usb: chipidea: msm: Restore wrapper settings after reset")
> Fixes: b74c43156c0c ("usb: chipidea: msm: ci_hdrc_msm_probe() missing of_node_get()")
> Cc: stable <stable@vger.kernel.org>     # 4.10: b74c43156c0c
> Cc: Stephen Boyd <stephen.boyd@linaro.org>
> Cc: Frank Rowand <frank.rowand@sony.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
>  drivers/usb/chipidea/ci_hdrc_msm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c
> index 3593ce0ec641..880009987460 100644
> --- a/drivers/usb/chipidea/ci_hdrc_msm.c
> +++ b/drivers/usb/chipidea/ci_hdrc_msm.c
> @@ -247,7 +247,7 @@ static int ci_hdrc_msm_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto err_mux;
>  
> -	ulpi_node = of_find_node_by_name(of_node_get(pdev->dev.of_node), "ulpi");
> +	ulpi_node = of_get_child_by_name(pdev->dev.of_node, "ulpi");

Stephen, would you comment on it? I am afraid I can't find the benefit
for this change.

-- 

Best Regards,
Peter Chen