Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752259AbdLLDee (ORCPT ); Mon, 11 Dec 2017 22:34:34 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:44032 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752141AbdLLDe3 (ORCPT ); Mon, 11 Dec 2017 22:34:29 -0500 X-Google-Smtp-Source: ACJfBouv5PIfR/qmhSl81Gebg29+9NqpS813KGQZTaS9zdD2yQsc8It2A2LBxBgl6oyXmMDI3H3BUg== To: klassert@mathematik.tu-chemnitz.de, vortex@scyld.com, becker@scyld.com, David Miller Cc: netdev@vger.kernel.org, Linux Kernel Mailing List From: Jia-Ju Bai Subject: [BUG] 3com/3c59x: two possible sleep-in-atomic bugs Message-ID: <601d2159-76d7-57ac-9d84-6e33a3352fbe@gmail.com> Date: Tue, 12 Dec 2017 11:34:18 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 606 Lines: 22 According to drivers/net/ethernet/3com/3c59x.c, the kernel module may sleep in the interrupt handler. The function call paths are: boomerang_interrupt (interrupt handler) vortex_error vortex_up pci_set_power_state --> may sleep pci_enable_device --> may sleep vortex_interrupt (interrupt handler) vortex_error vortex_up pci_set_power_state --> may sleep pci_enable_device --> may sleep I do not find a good way to fix them, so I only report. These possible bugs are found by my static analysis tool (DSAC) and checked by my code review. Thanks, Jia-Ju Bai