Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751678AbdLLDtv (ORCPT ); Mon, 11 Dec 2017 22:49:51 -0500 Received: from m12-16.163.com ([220.181.12.16]:60642 "EHLO m12-16.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751123AbdLLDtt (ORCPT ); Mon, 11 Dec 2017 22:49:49 -0500 Subject: Re: [PATCH] NCR5380: Fix a possible sleep-in-atomic bug in NCR5380_poll_politely2 To: Finn Thain Cc: schmitzmic@gmail.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai References: <1513047037-18102-1-git-send-email-baijiaju1990@163.com> From: Jia-Ju Bai Message-ID: <20fa69d8-7bfe-0ce4-b547-cc7372726bde@163.com> Date: Tue, 12 Dec 2017 11:49:32 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-CM-TRANSID: EMCowAB3cEPTUS9aUwBWDQ--.33961S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxUDLiSDUUUU X-Originating-IP: [166.111.70.3] X-CM-SenderInfo: xedlyx5dmximizq6il2tof0z/1tbiZROselWBXtvoUQAAsI Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 422 Lines: 16 Thanks for your reply :) On 2017/12/12 11:38, Finn Thain wrote: > On Tue, 12 Dec 2017, Jia-Ju Bai wrote: > >> From: Jia-Ju Bai >> >> The kernel module may sleep under a spinlock. > The spinlock is always taken in irq mode, and the > schedule_timeout_uninterruptible() is conditional on !irqs_disabled(). > I think I ignore this check, which causes a false bug report, sorry. Thanks, Jia-Ju Bai