Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752306AbdLLHJQ (ORCPT ); Tue, 12 Dec 2017 02:09:16 -0500 Received: from mail-eopbgr40057.outbound.protection.outlook.com ([40.107.4.57]:64544 "EHLO EUR03-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752126AbdLLHJN (ORCPT ); Tue, 12 Dec 2017 02:09:13 -0500 From: Yinbo Zhu To: Felipe Balbi , Greg Kroah-Hartman CC: Mathias Nyman , "open list:DESIGNWARE USB3 DRD IP DRIVER" , "open list:DESIGNWARE USB3 DRD IP DRIVER" , open list , Xiaobo Xie , Jerry Huang , Ran Wang Subject: RE: [PATCH v2] usb: host: Implement workaround for Erratum A-009611 Thread-Topic: [PATCH v2] usb: host: Implement workaround for Erratum A-009611 Thread-Index: AQHTcAyGjgXsnJgVWUy1+tsNjEwqHqM5PHCAgAAGbYCABCxycIAAayOAgAE05kA= Date: Tue, 12 Dec 2017 07:09:09 +0000 Message-ID: References: <20171208094942.46748-1-yinbo.zhu@nxp.com> <20171208094942.46748-2-yinbo.zhu@nxp.com> <20171208102111.GA16245@kroah.com> <87vahhpkhw.fsf@linux.intel.com> <87mv2pprz2.fsf@linux.intel.com> In-Reply-To: <87mv2pprz2.fsf@linux.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yinbo.zhu@nxp.com; x-originating-ip: [185.114.77.231] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM3PR04MB1490;6:5qS7WknpWzhjs6LKSk4czrpnVQLv9vgASJOvR7K2GMMUyJUNWpIEc4fwl0a5/F3j7xelgH6bil4sbLbjU+wrpEdZ1YOcTQd3nnbliPrXPOLM1xzn4wZZ2nLDA7sROK1EOQ9LIviG9BvhTy6IUumZNmvj+tWAgB3kDZR7QVZQ8InwrSARctUFjum/rEEmzlTgnQ4XrRFQlMEAM29DHW5UGVpshCNg5ojT/O28KEOkf0+EZ6mxyJqvGaMrhzJeAQUTAkCU+Sht3p+Eoq0x2BrMHEvzB+mRrPZEd3R6MoahFY36M1ZQn2BLXZ8xt1PqPTGsr+fBxce7Tf/J/aqXtRtdFBl766uUSSV3gcPxj9HyP4o=;5:WzoCSAx12Av6q3VapIfesvgKp4ysVPkSF+nqMkXQxaPE9AX0mSrrc2w+pIpx/MeSk+DywuL0sExOV6MQTwbtSSR+CQzNZliSciwqpG45aEFsAAu+JyLeXnjERznsC4ub1CmU/j5CR+MaUpj/BdDQI1Dgn4sSnKFWpuCyBARI5iA=;24:OC2k7Qv3iyhK+CsCU/M4ijhByNWRLTcJn6O7KVgqag8ZIUBvchATpGNvNjr7NS6bHFAGXgnBVU9aQmwxZoqYqxijhmzhLL0B5myM8wXyCB0=;7:D3QFIxkqoR+I44z5H4UIgNkIug8FQseCiry4TVPuC4SdspirRK0f7Dwco8O3SE395nOQFAp8VO8feeOt8oCCUKly8mr+sfxziYaCi4EpPWiSPQYCTqgmAb6t7ZTqymp23/JqvTp+GJc5OVYwmWVJWkl0l2id5l8BNj/rRAqr2mF4Tm5+kkjTPBA5jo+A8ySSZ1d1aIFks23VN0eCukwo0SBiMOb5Gi6bN349p7wVmprfJfPBfP0eL4BOQ8tLuwtb x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI;SCL:-1;SFV:NSPM;SFS:(10009020)(346002)(376002)(39860400002)(366004)(13464003)(199004)(189003)(8936002)(6436002)(106356001)(55016002)(105586002)(229853002)(2950100002)(33656002)(5660300001)(68736007)(2906002)(99286004)(76176011)(7696005)(66066001)(3280700002)(3660700001)(6506006)(6116002)(102836003)(3846002)(5250100002)(305945005)(2900100001)(74316002)(316002)(7736002)(8676002)(86362001)(93886005)(575784001)(53546010)(25786009)(81166006)(53936002)(54906003)(110136005)(6246003)(9686003)(14454004)(59450400001)(4326008)(97736004)(478600001)(81156014);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR04MB1490;H:AM3PR04MB1251.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-ms-office365-filtering-correlation-id: 9cec8170-f7e6-42cb-ec76-08d5412f3d62 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(48565401081)(2017052603307);SRVR:AM3PR04MB1490; x-ms-traffictypediagnostic: AM3PR04MB1490: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(185117386973197)(84791874153150)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(3231023)(10201501046)(6055026)(6041248)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(20161123564025)(6072148)(201708071742011);SRVR:AM3PR04MB1490;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:AM3PR04MB1490; x-forefront-prvs: 051900244E spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9cec8170-f7e6-42cb-ec76-08d5412f3d62 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2017 07:09:09.0704 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR04MB1490 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vBC79M6U013780 Content-Length: 1973 Lines: 57 -----Original Message----- From: Felipe Balbi [mailto:felipe.balbi@linux.intel.com] Sent: Monday, December 11, 2017 4:52 PM To: Yinbo Zhu ; Greg Kroah-Hartman Cc: Mathias Nyman ; open list:DESIGNWARE USB3 DRD IP DRIVER ; open list:DESIGNWARE USB3 DRD IP DRIVER ; open list ; Xiaobo Xie ; Jerry Huang ; Ran Wang Subject: RE: [PATCH v2] usb: host: Implement workaround for Erratum A-009611 >>Hi, >>(please break your lines at 80-characters) >>Yinbo Zhu writes: I had check it. Every line is less than 80-characters. >>> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index >>> 5cb3f6795b0b..071e7cea8cbb 100644 >>> --- a/drivers/usb/dwc3/core.c >>> +++ b/drivers/usb/dwc3/core.c >>> @@ -1106,6 +1106,9 @@ static void dwc3_get_properties(struct dwc3 >>> *dwc) >>> >>> dwc->quirk_reverse_in_out = device_property_read_bool(dev, >>> "snps,quirk_reverse_in_out"); > >>This was generated on vendor tree. This quirk doesn't exist in dwc3. >>Also, > >update your tree and review MAINTAINERS file. It has been almost 2 > years since I left TI :-) > >>-- >>Balbi > > Hi Balbi, > > The quirk that I had add it in dwc3. Your meaning is that I can't use > quirk to enable or disable the erratum, isn't it? The tree is > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git, I had > updated it. >-*- mode: grep; default-directory: "~/workspace/linux/" -*- Grep started at Mon Dec 11 10:50:47 >git --no-pager grep --color -nH -e quirk_reverse_in_out >Grep finished with no matches found at Mon Dec 11 10:50:48 >-- >balbi Hi Balbi, You can't find the quirk that it is normal. There's no one in the previous code. The quirk that I added to control the new erratum Please you note. Thanks. Yinbo.