Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752126AbdLLHly (ORCPT ); Tue, 12 Dec 2017 02:41:54 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:35312 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751507AbdLLHlu (ORCPT ); Tue, 12 Dec 2017 02:41:50 -0500 X-Google-Smtp-Source: ACJfBotsKtFAmA5gUHHdDVpy9xu4wScVK7vaUhvf8mZUVLLcQr6xkVMbxYATpEVePRf+LtXh5jPW/Q== Subject: Re: [RFT PATCH] ARM: dts: exynos: Enable Mixer node for Exynos5800 Peach Pi machine To: Marek Szyprowski , linux-kernel@vger.kernel.org Cc: Guillaume Tucker , Daniel Vetter , Shuah Khan , devicetree@vger.kernel.org, Kukjin Kim , Russell King , linux-samsung-soc@vger.kernel.org, Rob Herring , Mark Rutland , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org References: <20171211224856.29264-1-javierm@redhat.com> <3e6e4b15-9f8a-bea1-3c8e-2d85fc4c512d@samsung.com> From: Javier Martinez Canillas Message-ID: <2dcc4a3d-bb9a-8338-8273-c5eae58dce34@redhat.com> Date: Tue, 12 Dec 2017 08:41:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <3e6e4b15-9f8a-bea1-3c8e-2d85fc4c512d@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2438 Lines: 77 Hello Marek, On 12/12/2017 08:01 AM, Marek Szyprowski wrote: > Hi > > On 2017-12-11 23:48, Javier Martinez Canillas wrote: >> Commit 1cb686c08d12 ("ARM: dts: exynos: Add status property to Exynos 542x >> Mixer nodes") disabled the Mixer node by default in the DTSI and enabled >> for each Exynos 542x DTS. But unfortunately it missed to enable it for the >> Exynos5800 Peach Pi machine, since the 5800 is also an 542x SoC variant. >> >> Signed-off-by: Javier Martinez Canillas > > Acked-by: Marek Szyprowski > Thanks. >> --- >> >> I believe this may cause the boot issues reported on Exynos5800 Peach Pi >> from v4.15-rc3, the mentioned commit made to v4.15-rc1 but it seems that >> didn't cause any harm until commit ("510353a63796 drm/bridge: analogix >> dp: Fix runtime PM state in get_modes() callback") fixed the runtime PM >> management in the DP driver. > > Thanks for analyzing this. Lack of this change was probably responsible for > Exynos DRM initialization failure ("exynos-drm exynos-drm: failed to bind > 14530000.hdmi (ops hdmi_component_ops): -1" message and probably further > error "unbalanced disables for lcd_vdd", which shows that failure path of > analogix dp and simple panel causes unbalanced regulator disable. > Yes, I came to the same conclusion than you in the thread started by Guillaume. I just couldn't test it. > This patch should go to v4.15-rcX (fixes) if possible. > Indeed. I wondered if it also needed a Fixes tag. I didn't include it because I thought that both the culprit and the fix would be in the same kernel release. But I'll include it anyways. >> I can't test right now, but I'm posting anyways as a RFT in case others >> that have access to a Peach Pi can test it. >> >> Best regards, >> Javier >> >> arch/arm/boot/dts/exynos5800-peach-pi.dts | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts >> index b2b95ff205e8..0029ec27819c 100644 >> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts >> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts >> @@ -664,6 +664,10 @@ >> status = "okay"; >> }; >> >> +&mixer { >> + status = "okay"; >> +}; >> + >> /* eMMC flash */ >> &mmc_0 { >> status = "okay"; > > Best regards > Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat