Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751871AbdLLIY3 (ORCPT ); Tue, 12 Dec 2017 03:24:29 -0500 Received: from nbd.name ([46.4.11.11]:57382 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750715AbdLLIY1 (ORCPT ); Tue, 12 Dec 2017 03:24:27 -0500 Subject: Re: [PATCH net-next 1/3] net: dsa: mediatek: add VLAN support for MT7530 To: sean.wang@mediatek.com, davem@davemloft.net, andrew@lunn.ch, f.fainelli@gmail.com, vivien.didelot@savoirfairelinux.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org References: <792c2d52b8da717b55ead9d480863ca390fe91b3.1512625814.git.sean.wang@mediatek.com> From: Felix Fietkau Message-ID: <94df4a0c-3e9b-a51e-6f2d-5adc43e3b9e4@nbd.name> Date: Tue, 12 Dec 2017 09:24:10 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <792c2d52b8da717b55ead9d480863ca390fe91b3.1512625814.git.sean.wang@mediatek.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 245 Lines: 7 On 2017-12-07 07:06, sean.wang@mediatek.com wrote: > From: Sean Wang > > MT7530 can treat each port as either VLAN-unware port or VLAN-ware port Shouldn't that be VLAN-unaware/VLAN-aware (in the code as well)? - Felix