Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752273AbdLLIid (ORCPT ); Tue, 12 Dec 2017 03:38:33 -0500 Received: from mail-it0-f68.google.com ([209.85.214.68]:39746 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751871AbdLLIi0 (ORCPT ); Tue, 12 Dec 2017 03:38:26 -0500 X-Google-Smtp-Source: ACJfBouEJFRxMq6NH2unoLwax5ucw13I8H5XLqXS7IUQ+pDuTQ87Z2XJBW9+BS8L23JIQzEOCBDuWw== To: mlindner@marvell.com, stephen@networkplumber.org, shemminger@osdl.org, shemminger@linux-foundation.org Cc: netdev@vger.kernel.org, Linux Kernel Mailing List From: Jia-Ju Bai Subject: [BUG] skge: a possible sleep-in-atomic bug in skge_remove Message-ID: <1e8a8196-f0d1-2a82-3632-b882787c4391@gmail.com> Date: Tue, 12 Dec 2017 16:38:12 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 347 Lines: 13 According to drivers/net/ethernet/marvell/skge.c, the driver may sleep under a spinlock. The function call path is: skge_remove (acquire the spinlock) free_irq --> may sleep I do not find a good way to fix it, so I only report. This possible bug is found by my static analysis tool (DSAC) and checked by my code review. Thanks, Jia-Ju Bai