Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752161AbdLLJzo (ORCPT <rfc822;w@1wt.eu>);
        Tue, 12 Dec 2017 04:55:44 -0500
Received: from mail.kernel.org ([198.145.29.99]:46520 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750853AbdLLJzj (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 12 Dec 2017 04:55:39 -0500
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C67CC2187A
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=krzk@kernel.org
X-Google-Smtp-Source: ACJfBoskTweYBoT+siC2N1+tVSj9FsH4bVf91wCn8zVA12k7bPhBz1DFsrUrr/9v456uEu8MAvSeBZu6j9fqQAak1GM=
MIME-Version: 1.0
In-Reply-To: <20171212074208.30753-1-javierm@redhat.com>
References: <20171212074208.30753-1-javierm@redhat.com>
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: Tue, 12 Dec 2017 10:55:36 +0100
X-Gmail-Original-Message-ID: <CAJKOXPc1rJCWABXUuyU2MKxnLY-MptrM9Mm0HyHVCJn870R+sg@mail.gmail.com>
Message-ID: <CAJKOXPc1rJCWABXUuyU2MKxnLY-MptrM9Mm0HyHVCJn870R+sg@mail.gmail.com>
Subject: Re: [PATCH v2] ARM: dts: exynos: Enable Mixer node for Exynos5800
 Peach Pi machine
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: linux-kernel@vger.kernel.org,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Guillaume Tucker <guillaume.tucker@collabora.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        Shuah Khan <shuahkh@osg.samsung.com>, devicetree@vger.kernel.org,
        Kukjin Kim <kgene@kernel.org>, Russell King <linux@armlinux.org.uk>,
        linux-samsung-soc@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1370
Lines: 46

On Tue, Dec 12, 2017 at 8:42 AM, Javier Martinez Canillas
<javierm@redhat.com> wrote:
> Commit 1cb686c08d12 ("ARM: dts: exynos: Add status property to Exynos 542x
> Mixer nodes") disabled the Mixer node by default in the DTSI and enabled
> for each Exynos 542x DTS. But unfortunately it missed to enable it for the
> Exynos5800 Peach Pi machine, since the 5800 is also an 542x SoC variant.
>
> Fixes: 1cb686c08d12 ("ARM: dts: exynos: Add status property to Exynos 542x Mixer nodes")
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
>
> ---
>
> Changes in v2:
> - Remove RFT tag.

Thanks guys! However I still would like to see a tested-by for this on
Peach Pi (AFAIU, Marek's only acked the code/solution).

Best regards,
Krzysztof

> - Add Marek's Acked-by tag.
> - Add fixes tag.
>
>  arch/arm/boot/dts/exynos5800-peach-pi.dts | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
> index b2b95ff205e8..0029ec27819c 100644
> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
> @@ -664,6 +664,10 @@
>         status = "okay";
>  };
>
> +&mixer {
> +       status = "okay";
> +};
> +
>  /* eMMC flash */
>  &mmc_0 {
>         status = "okay";
> --
> 2.14.3
>