Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752408AbdLLKwG (ORCPT ); Tue, 12 Dec 2017 05:52:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:36940 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752349AbdLLKwC (ORCPT ); Tue, 12 Dec 2017 05:52:02 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A3EFB2187A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=krzk@kernel.org X-Google-Smtp-Source: ACJfBou1KKhTlair/D4uSbyXwNyC9s+sV7hPB2PaWLOfy6iQpYfg4m2HgsapdJG4ZtBSL89vKmaK27bsBjjtn58LFBE= MIME-Version: 1.0 In-Reply-To: References: <20171212074208.30753-1-javierm@redhat.com> From: Krzysztof Kozlowski Date: Tue, 12 Dec 2017 11:51:59 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] ARM: dts: exynos: Enable Mixer node for Exynos5800 Peach Pi machine To: Guillaume Tucker Cc: Marek Szyprowski , Javier Martinez Canillas , linux-kernel@vger.kernel.org, Daniel Vetter , Shuah Khan , devicetree@vger.kernel.org, Kukjin Kim , Russell King , linux-samsung-soc@vger.kernel.org, Rob Herring , Mark Rutland , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2159 Lines: 66 On Tue, Dec 12, 2017 at 11:43 AM, Guillaume Tucker wrote: > On 12/12/17 10:17, Marek Szyprowski wrote: >> >> Hi Krzysztof, >> >> On 2017-12-12 11:09, Krzysztof Kozlowski wrote: >>> >>> On Tue, Dec 12, 2017 at 10:55 AM, Krzysztof Kozlowski >>> wrote: >>>> >>>> On Tue, Dec 12, 2017 at 8:42 AM, Javier Martinez Canillas >>>> wrote: >>>>> >>>>> Commit 1cb686c08d12 ("ARM: dts: exynos: Add status property to Exynos >>>>> 542x >>>>> Mixer nodes") disabled the Mixer node by default in the DTSI and >>>>> enabled >>>>> for each Exynos 542x DTS. But unfortunately it missed to enable it for >>>>> the >>>>> Exynos5800 Peach Pi machine, since the 5800 is also an 542x SoC >>>>> variant. >>>>> >>>>> Fixes: 1cb686c08d12 ("ARM: dts: exynos: Add status property to Exynos >>>>> 542x Mixer nodes") >>>>> Signed-off-by: Javier Martinez Canillas >>>>> Acked-by: Marek Szyprowski >>>>> >>>>> --- >>>>> >>>>> Changes in v2: >>>>> - Remove RFT tag. >>>> >>>> Thanks guys! However I still would like to see a tested-by for this on >>>> Peach Pi (AFAIU, Marek's only acked the code/solution). >>> >>> On the other hand I could just apply it for my for-next branch and >>> we'll see if it fixes kernel-ci boot tests... Not a nice way of >>> testing but apparently no one has Peach Pi. >> >> >> Frankly, I don't expect that this will solve the boot hang issue on >> PeachPi. >> However it should at least hide the unbalanced regulator issue. > > > We have a peach-pi in our LAVA lab so I've tested it and > actually, it does fix the hang on v4.15-rc3: > > https://lava.collabora.co.uk/scheduler/job/1019877 > https://lava.collabora.co.uk/scheduler/job/1019878 > > I ran it twice and it booted both times. I also ran the same > boot tests with the same kernel but the dtb from v4.15-rc3 > without the fix to double check and these failed: > > https://lava.collabora.co.uk/scheduler/job/1019879 > https://lava.collabora.co.uk/scheduler/job/1019880 > > > Tested-by: Guillaume Tucker Thank you! Best regards, Krzysztof