Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752209AbdLLLHR (ORCPT ); Tue, 12 Dec 2017 06:07:17 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:60684 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750731AbdLLLHM (ORCPT ); Tue, 12 Dec 2017 06:07:12 -0500 Subject: Re: [PATCH v2] ARM: dts: exynos: Enable Mixer node for Exynos5800 Peach Pi machine To: Marek Szyprowski , Krzysztof Kozlowski , Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Daniel Vetter , Shuah Khan , devicetree@vger.kernel.org, Kukjin Kim , Russell King , linux-samsung-soc@vger.kernel.org, Rob Herring , Mark Rutland , linux-arm-kernel@lists.infradead.org References: <20171212074208.30753-1-javierm@redhat.com> <1bbedec6-6250-f02a-bf9a-4b9849833de2@samsung.com> From: Guillaume Tucker Message-ID: <4a8edb50-72cf-8603-8ba5-5176cbef9636@collabora.com> Date: Tue, 12 Dec 2017 11:07:06 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1bbedec6-6250-f02a-bf9a-4b9849833de2@samsung.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2903 Lines: 70 On 12/12/17 10:55, Marek Szyprowski wrote: > Hi Guillaume, > > On 2017-12-12 11:43, Guillaume Tucker wrote: >> On 12/12/17 10:17, Marek Szyprowski wrote: >>> Hi Krzysztof, >>> >>> On 2017-12-12 11:09, Krzysztof Kozlowski wrote: >>>> On Tue, Dec 12, 2017 at 10:55 AM, Krzysztof Kozlowski wrote: >>>>> On Tue, Dec 12, 2017 at 8:42 AM, Javier Martinez Canillas >>>>> wrote: >>>>>> Commit 1cb686c08d12 ("ARM: dts: exynos: Add status property to Exynos 542x >>>>>> Mixer nodes") disabled the Mixer node by default in the DTSI and enabled >>>>>> for each Exynos 542x DTS. But unfortunately it missed to enable it for the >>>>>> Exynos5800 Peach Pi machine, since the 5800 is also an 542x SoC variant. >>>>>> >>>>>> Fixes: 1cb686c08d12 ("ARM: dts: exynos: Add status property to Exynos 542x Mixer nodes") >>>>>> Signed-off-by: Javier Martinez Canillas >>>>>> Acked-by: Marek Szyprowski >>>>>> >>>>>> --- >>>>>> >>>>>> Changes in v2: >>>>>> - Remove RFT tag. >>>>> Thanks guys! However I still would like to see a tested-by for this on >>>>> Peach Pi (AFAIU, Marek's only acked the code/solution). >>>> On the other hand I could just apply it for my for-next branch and >>>> we'll see if it fixes kernel-ci boot tests... Not a nice way of >>>> testing but apparently no one has Peach Pi. >>> >>> Frankly, I don't expect that this will solve the boot hang issue on PeachPi. >>> However it should at least hide the unbalanced regulator issue. >> >> We have a peach-pi in our LAVA lab so I've tested it and >> actually, it does fix the hang on v4.15-rc3: >> >>   https://lava.collabora.co.uk/scheduler/job/1019877 >>   https://lava.collabora.co.uk/scheduler/job/1019878 >> >> I ran it twice and it booted both times.  I also ran the same >> boot tests with the same kernel but the dtb from v4.15-rc3 >> without the fix to double check and these failed: >> >>   https://lava.collabora.co.uk/scheduler/job/1019879 >>   https://lava.collabora.co.uk/scheduler/job/1019880 >> >> >> Tested-by: Guillaume Tucker >> >> >> Thanks for the fix! > > Well, thanks for the test! It proves that there the boot failure is > caused by an issue somewhere in the error path of Exynos DRM, Analogix > DP, Simple Panel or other drivers. > > This patch simply hides it by fixing the source issue of the Exynos > DRM initialization failure. :-) > > I hope Javier will be able to investigate the discussed hang issue > later, as fixing it is also imho important. Sure. This device tree change is needed to get HDMI to work so it's still a fix for that. Also it's good to know that nothing else breaks when the driver issue is "hidden". Might be worth testing on -next as well as it might help spot any new issues that haven't been merged in mainline yet, or in general give another data point. Guillaume