Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752543AbdLLLj4 (ORCPT ); Tue, 12 Dec 2017 06:39:56 -0500 Received: from mail-lf0-f68.google.com ([209.85.215.68]:45412 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752316AbdLLLjq (ORCPT ); Tue, 12 Dec 2017 06:39:46 -0500 X-Google-Smtp-Source: ACJfBotfGYO120MjjQUaW1CZ0VywoKJwIucCBn36+S6OOgkwVtxEUS3gi1SlbIsCq31VHduMXxQn7A== Subject: Re: [PATCH v1 2/2] usb: chipidea: tegra: Select Tegra's PHY in Kconfig To: Peter Chen Cc: Thierry Reding , Felipe Balbi , Alan Stern , Greg Kroah-Hartman , Jonathan Hunter , Peter Chen , linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171211100400.GE10671@ulmo> <6dddb581-e708-b96e-cf56-f3bf106117e2@gmail.com> <20171212025444.GA22364@b29397-desktop> From: Dmitry Osipenko Message-ID: <37461928-a078-9247-ebad-c4a18fbd91ef@gmail.com> Date: Tue, 12 Dec 2017 14:39:41 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171212025444.GA22364@b29397-desktop> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1959 Lines: 44 On 12.12.2017 05:54, Peter Chen wrote: > On Mon, Dec 11, 2017 at 04:09:44PM +0300, Dmitry Osipenko wrote: >> On 11.12.2017 13:04, Thierry Reding wrote: >>> On Mon, Dec 11, 2017 at 02:10:00AM +0300, Dmitry Osipenko wrote: >>>> UDC driver won't probe without Tegra's PHY, hence select it in the >>>> Kconfig. >>>> >>>> Signed-off-by: Dmitry Osipenko >>>> --- >>>> drivers/usb/chipidea/Kconfig | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/drivers/usb/chipidea/Kconfig b/drivers/usb/chipidea/Kconfig >>>> index 785f0ed037f7..2ef3b27ea72b 100644 >>>> --- a/drivers/usb/chipidea/Kconfig >>>> +++ b/drivers/usb/chipidea/Kconfig >>>> @@ -27,6 +27,7 @@ config USB_CHIPIDEA_PCI >>>> config USB_CHIPIDEA_UDC >>>> bool "ChipIdea device controller" >>>> depends on USB_GADGET >>>> + select USB_TEGRA_PHY if ARCH_TEGRA >>> >>> This is kind of pointless given that USB_TEGRA_PHY originally was >>> automatically enabled if ARCH_TEGRA was enabled. >> >> Again, please take a closer look at the patches. USB_TEGRA_PHY was enabled if >> USB_EHCI_TEGRA was and not ARCH_TEGRA. >> >>> What do we gain by these two patches, other than maybe make the driver >>> buildable as a module? >> >> Firstly, tegra-phy is built only if ehci-tegra is built. >> >> Secondly, I think we need to enforce Tegra PHY to be compiled as built-in if one >> of ehci-tegra or chipidea drivers is built-in and the other is compiled as a module. > > You may not bind controller driver with PHY driver in Kconfig, we need > to make sure the controller driver has no build error if the PHY driver > is not select. And if the PHY driver is not loaded, the controller > driver should return -EPROBE_DEFER for it. Okay, I'll drop the ChipIdea Kconfig patch and remove USB_TEGRA_PHY selection in USB_EHCI_TEGRA config entry in the next iteration of the patch. Also, I noticed that USB_ULPI* selection should be moved from ehci-tegra to tegra-phy Kconfig entry.