Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752470AbdLLMFJ (ORCPT ); Tue, 12 Dec 2017 07:05:09 -0500 Received: from mga12.intel.com ([192.55.52.136]:33990 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752403AbdLLMFF (ORCPT ); Tue, 12 Dec 2017 07:05:05 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,395,1508828400"; d="scan'208";a="158033629" Content-Type: text/plain; charset=iso-8859-15; format=flowed; delsp=yes To: joonas.lahtinen@linux.intel.com, chris@chris-wilson.co.uk, sagar.a.kamble@intel.com, jani.nikula@linux.intel.com, rodrigo.vivi@intel.com, airlied@linux.ie, daniel.vetter@intel.com, seanpaul@chromium.org, corbet@lwn.net, "Markus Heiser" Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] docs: fix, intel_guc_loader.c has been moved to intel_guc_fw.c References: <1513078717-12373-1-git-send-email-markus.heiser@darmarit.de> Date: Tue, 12 Dec 2017 13:05:00 +0100 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: "Michal Wajdeczko" Message-ID: In-Reply-To: <1513078717-12373-1-git-send-email-markus.heiser@darmarit.de> User-Agent: Opera Mail/1.0 (Win32) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 969 Lines: 29 On Tue, 12 Dec 2017 12:38:37 +0100, Markus Heiser wrote: > With commit d9e2e0143c the 'GuC-specific firmware loader' doc > section was removed from intel_guc_loader.c without a > replacement. So lets remove it from the Kernel-doc:: > > .. kernel-doc:: drivers/gpu/drm/i915/intel_guc_loader.c > :doc: GuC-specific firmware loader > > With commit e8668bbcb0 intel_guc_loader.c was renamed to to > intel_guc_fw.c and to name just one, intel_guc_init_hw() was > renamed to intel_guc_fw_upload(). Since we get errors in the > Sphinx build like: > > - Error: Cannot open file ./drivers/gpu/drm/i915/intel_guc_loader.c > > Change the kernel-doc directive from intel_guc_loader.c to > intel_guc_fw.c > > Signed-off-by: Markus Heiser > --- Thanks for your patch, but similar fix is already merged here [1] Michal [1] https://cgit.freedesktop.org/drm-tip/commit/?id=006c23327f8de8575508c458131b304188d426f7