Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752217AbdLLMMb convert rfc822-to-8bit (ORCPT ); Tue, 12 Dec 2017 07:12:31 -0500 Received: from smtp3-1.goneo.de ([85.220.129.38]:42230 "EHLO smtp3-1.goneo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750749AbdLLMM3 (ORCPT ); Tue, 12 Dec 2017 07:12:29 -0500 X-Spam-Flag: NO X-Spam-Score: -2.762 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [PATCH] docs: fix, intel_guc_loader.c has been moved to intel_guc_fw.c From: Markus Heiser In-Reply-To: Date: Tue, 12 Dec 2017 13:11:43 +0100 Cc: joonas.lahtinen@linux.intel.com, Chris Wilson , sagar.a.kamble@intel.com, jani.nikula@linux.intel.com, rodrigo.vivi@intel.com, airlied@linux.ie, daniel.vetter@intel.com, seanpaul@chromium.org, Jonathan Corbet , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Linux Doc Mailing List , linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <5E91F865-18A3-4C79-8EEE-B228EB188496@darmarit.de> References: <1513078717-12373-1-git-send-email-markus.heiser@darmarit.de> To: Michal Wajdeczko , Randy Dunlap X-Mailer: Apple Mail (2.3273) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1501 Lines: 46 > Am 12.12.2017 um 13:05 schrieb Michal Wajdeczko : > > On Tue, 12 Dec 2017 12:38:37 +0100, Markus Heiser wrote: > >> With commit d9e2e0143c the 'GuC-specific firmware loader' doc >> section was removed from intel_guc_loader.c without a >> replacement. So lets remove it from the Kernel-doc:: >> >> .. kernel-doc:: drivers/gpu/drm/i915/intel_guc_loader.c >> :doc: GuC-specific firmware loader >> >> With commit e8668bbcb0 intel_guc_loader.c was renamed to to >> intel_guc_fw.c and to name just one, intel_guc_init_hw() was >> renamed to intel_guc_fw_upload(). Since we get errors in the >> Sphinx build like: >> >> - Error: Cannot open file ./drivers/gpu/drm/i915/intel_guc_loader.c >> >> Change the kernel-doc directive from intel_guc_loader.c to >> intel_guc_fw.c >> >> Signed-off-by: Markus Heiser >> --- > > Thanks for your patch, but similar fix is already merged here [1] > > Michal > > [1] https://cgit.freedesktop.org/drm-tip/commit/?id=006c23327f8de8575508c458131b304188d426f7 Thanks for pointing out. I miss the ":doc: GuC-specific firmware loader" fix in that patch (doc section was removed in d9e2e0143c). Can you or someone else from @intel fix this also? Thanks! -- Markus -- > -- > To unsubscribe from this list: send the line "unsubscribe linux-doc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html