Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754368AbdLLNew (ORCPT ); Tue, 12 Dec 2017 08:34:52 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:49522 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754139AbdLLNes (ORCPT ); Tue, 12 Dec 2017 08:34:48 -0500 Date: Tue, 12 Dec 2017 08:34:45 -0500 (EST) Message-Id: <20171212.083445.2256119006373036925.davem@davemloft.net> To: baijiaju1990@gmail.com Cc: mlindner@marvell.com, stephen@networkplumber.org, shemminger@osdl.org, shemminger@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [BUG] skge: a possible sleep-in-atomic bug in skge_remove From: David Miller In-Reply-To: <1e8a8196-f0d1-2a82-3632-b882787c4391@gmail.com> References: <1e8a8196-f0d1-2a82-3632-b882787c4391@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 12 Dec 2017 05:34:47 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 723 Lines: 26 From: Jia-Ju Bai Date: Tue, 12 Dec 2017 16:38:12 +0800 > According to drivers/net/ethernet/marvell/skge.c, the driver may sleep > under a spinlock. > The function call path is: > skge_remove (acquire the spinlock) > free_irq --> may sleep > > I do not find a good way to fix it, so I only report. > This possible bug is found by my static analysis tool (DSAC) and > checked by my code review. This was added by: commit a9e9fd7182332d0cf5f3e601df3e71dd431b70d7 Author: Stephen Hemminger Date: Tue Sep 27 13:41:37 2011 -0400 skge: handle irq better on single port card I think the free_irq() can be moved below the unlock. Stephen, please take a look. Thanks!