Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752243AbdLLOmT (ORCPT ); Tue, 12 Dec 2017 09:42:19 -0500 Received: from mga01.intel.com ([192.55.52.88]:48096 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751234AbdLLOmS (ORCPT ); Tue, 12 Dec 2017 09:42:18 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,395,1508828400"; d="scan'208";a="11233574" Date: Tue, 12 Dec 2017 07:45:56 -0700 From: Keith Busch To: Nikolay Borisov Cc: Scott Bauer , dm-devel@redhat.com, snitzer@redhat.com, agk@redhat.com, linux-kernel@vger.kernel.org, jonathan.derrick@intel.com Subject: Re: [PATCH v2 2/2] dm unstripe: Add documentation for unstripe target Message-ID: <20171212144556.GF11218@localhost.localdomain> References: <20171211160019.20518-1-scott.bauer@intel.com> <20171211160019.20518-3-scott.bauer@intel.com> <00fdc58c-d8e9-6b42-727d-ab70d5ce1b0a@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <00fdc58c-d8e9-6b42-727d-ab70d5ce1b0a@gmail.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 961 Lines: 21 On Tue, Dec 12, 2017 at 01:35:13PM +0200, Nikolay Borisov wrote: > On 11.12.2017 18:00, Scott Bauer wrote: > > + As an example: > > + > > + Intel NVMe drives contain two cores on the physical device. > > + Each core of the drive has segregated access to its LBA range. > > + The current LBA model has a RAID 0 128k stripe across the two cores: > > + > > + Core 0: Core 1: > > + __________ __________ > > + | LBA 511| | LBA 768| > > + | LBA 0 | | LBA 256| > > + ⎻⎻⎻⎻⎻⎻⎻⎻⎻⎻ ⎻⎻⎻⎻⎻⎻⎻⎻⎻⎻ > > If it's 128k stripe shouldn't it be LBAs 0/256 on core0 and LBAs 128/511 > on core1? Ah, this device's makers call the "stripe" size what should be called "chunk". This device has a 128k chunk per core with two cores, so the full stripe is 256k. The above should have core 0 owning LBA 512 rather than 511 (assuming 512b LBA format).