Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752888AbdLLPBv convert rfc822-to-8bit (ORCPT ); Tue, 12 Dec 2017 10:01:51 -0500 Received: from prv-mh.provo.novell.com ([137.65.248.74]:35243 "EHLO prv-mh.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752433AbdLLPBt (ORCPT ); Tue, 12 Dec 2017 10:01:49 -0500 Message-Id: <5A2FFD690200007800196DFB@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.2 Date: Tue, 12 Dec 2017 08:01:45 -0700 From: "Jan Beulich" To: "Govinda Tatti" Cc: , , , , , "Juergen Gross" , , Subject: Re: [PATCH V3 2/2] Xen/PCIback: Implement PCI flr/slot/bus reset with 'reset' SysFS attribute References: <20171207222145.9769-1-Govinda.Tatti@Oracle.COM> <20171207222145.9769-3-Govinda.Tatti@Oracle.COM> <5A2A6AB10200007800195D4F@prv-mh.provo.novell.com> <8a3bc517-1255-4547-d244-5c400e44cc77@Oracle.COM> In-Reply-To: <8a3bc517-1255-4547-d244-5c400e44cc77@Oracle.COM> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1655 Lines: 37 >>> On 12.12.17 at 15:48, wrote: > Thanks Jan for your review comments. Please see below for my comments. First of all - can you please do something about your reply style? HTML mail should be avoided. You'll see that the (plain text) reply as a result is rather hard to follow, too. > --- a/Documentation/ABI/testing/sysfs-driver-pciback > +++ b/Documentation/ABI/testing/sysfs-driver-pciback > @@ -11,3 +11,18 @@ Description: > #echo 00:19.0-E0:2:FF > /sys/bus/pci/drivers/pciback/quirks > will allow the guest to read and write to the configuration > register 0x0E. > + > +What: /sys/bus/pci/drivers/pciback/reset > +Date: Dec 2017 > +KernelVersion: 4.15 > +Contact: xen-devel@lists.xenproject.org > +Description: > + An option to perform a flr/slot/bus reset when a PCI device > + is owned by Xen PCI backend. Writing a string of DDDD:BB:DD.F > SSSS:BB:DD.F (or else the D-s are ambiguous, the more that "domain" > in Xen code is ambiguous anyway - I continue to be mislead by struct > pcistub_device_id's domain field) Thanks for catching this issue. I will > fix it. > > > Also I assume the SSSS part is optional (default zero), which > probably can and should be expressed in some way. SSSS can be 0 or > non-zero, subject to system configuration. The question isn't system configuration, but whether the field can be omitted on input, with zero being assumed in such a case. That's a common shorthand, considering that the vast majority of x86 (and maybe other) systems aren't using segments other than zero. Jan