Date: Tue, 12 Dec 2017 16:23:59 +0100
From: Daniel Vetter <daniel@ffwll.ch>
To: Markus Heiser <markus.heiser@darmarit.de>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>,
        Randy Dunlap <rdunlap@infradead.org>, joonas.lahtinen@linux.intel.com,
        Chris Wilson <chris@chris-wilson.co.uk>, sagar.a.kamble@intel.com,
        jani.nikula@linux.intel.com, rodrigo.vivi@intel.com, airlied@linux.ie,
        daniel.vetter@intel.com, seanpaul@chromium.org,
        Jonathan Corbet <corbet@lwn.net>, intel-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org,
        Linux Doc Mailing List <linux-doc@vger.kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: fix, intel_guc_loader.c has been moved to
 intel_guc_fw.c
Message-ID: <20171212152359.GC526@phenom.ffwll.local>
Mail-Followup-To: Markus Heiser <markus.heiser@darmarit.de>,
        Michal Wajdeczko <michal.wajdeczko@intel.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        joonas.lahtinen@linux.intel.com,
        Chris Wilson <chris@chris-wilson.co.uk>, sagar.a.kamble@intel.com,
        jani.nikula@linux.intel.com, rodrigo.vivi@intel.com,
        airlied@linux.ie, daniel.vetter@intel.com, seanpaul@chromium.org,
        Jonathan Corbet <corbet@lwn.net>, intel-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org,
        Linux Doc Mailing List <linux-doc@vger.kernel.org>,
        linux-kernel@vger.kernel.org
References: <1513078717-12373-1-git-send-email-markus.heiser@darmarit.de>
 <op.za4uimy6xaggs7@mwajdecz-mobl1.ger.corp.intel.com>
 <5E91F865-18A3-4C79-8EEE-B228EB188496@darmarit.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5E91F865-18A3-4C79-8EEE-B228EB188496@darmarit.de>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1582
Lines: 45

On Tue, Dec 12, 2017 at 01:11:43PM +0100, Markus Heiser wrote:
> 
> > Am 12.12.2017 um 13:05 schrieb Michal Wajdeczko <michal.wajdeczko@intel.com>:
> > 
> > On Tue, 12 Dec 2017 12:38:37 +0100, Markus Heiser <markus.heiser@darmarit.de> wrote:
> > 
> >> With commit d9e2e0143c the 'GuC-specific firmware loader' doc
> >> section was removed from intel_guc_loader.c without a
> >> replacement.  So lets remove it from the Kernel-doc::
> >> 
> >>  .. kernel-doc:: drivers/gpu/drm/i915/intel_guc_loader.c
> >>     :doc: GuC-specific firmware loader
> >> 
> >> With commit e8668bbcb0 intel_guc_loader.c was renamed to to
> >> intel_guc_fw.c and to name just one, intel_guc_init_hw() was
> >> renamed to intel_guc_fw_upload(). Since we get errors in the
> >> Sphinx build like:
> >> 
> >> - Error: Cannot open file ./drivers/gpu/drm/i915/intel_guc_loader.c
> >> 
> >> Change the kernel-doc directive from intel_guc_loader.c to
> >> intel_guc_fw.c
> >> 
> >> Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
> >> ---
> > 
> > Thanks for your patch, but similar fix is already merged here [1]
> > 
> > Michal
> > 
> > [1] https://cgit.freedesktop.org/drm-tip/commit/?id=006c23327f8de8575508c458131b304188d426f7
> 
> 
> Thanks for pointing out. I miss the ":doc: GuC-specific firmware loader"
> fix in that patch (doc section was removed in d9e2e0143c).  Can you or
> someone else from @intel fix this also?

I've rebased the patch from you to only take that remaining part.

Thanks for fixing this.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch