Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752431AbdLLP37 (ORCPT ); Tue, 12 Dec 2017 10:29:59 -0500 Received: from 19.mo4.mail-out.ovh.net ([87.98.179.66]:32989 "EHLO 19.mo4.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751609AbdLLP36 (ORCPT ); Tue, 12 Dec 2017 10:29:58 -0500 X-Greylist: delayed 7793 seconds by postgrey-1.27 at vger.kernel.org; Tue, 12 Dec 2017 10:29:58 EST Date: Tue, 12 Dec 2017 22:03:13 +0900 From: Andi Shyti To: Krzysztof Kozlowski Cc: Andi Shyti , Kukjin Kim , Mark Brown , linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti Subject: Re: [PATCH] spi: s3c64xx: add SPDX identifier Message-ID: <20171212130313.GC1072@brancaleone.zhora.eu> References: <20171212075815.8683-1-andi.shyti@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) X-Ovh-Tracer-Id: 15249188342105817753 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtuddrvdekgdeflecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1210 Lines: 36 Hi Krzysztof, > > - * Copyright (C) 2009 Samsung Electronics Ltd. > > - * Jaswinder Singh > > - * > > - * This program is free software; you can redistribute it and/or modify > > - * it under the terms of the GNU General Public License as published by > > - * the Free Software Foundation; either version 2 of the License, or > > - * (at your option) any later version. > > - * > > - * This program is distributed in the hope that it will be useful, > > - * but WITHOUT ANY WARRANTY; without even the implied warranty of > > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > - * GNU General Public License for more details. > > - */ > > +// SPDX-License-Identifier: GPL-2.0 > > Existing license corresponds to GPL-2.0+, not GPL-2.0. mmmhhh... isn't it deprecated from 2.0rc2? Current SPDX version 2.6 doesn't have GPL-2.0+ in the list of licenses. https://spdx.org/licenses/ I can improve the commit log to state it more clearly. Would that work? BTW, is it really a change of license? > Why changing the comment style? That's SPDX, right? by adding the SPDX-License-Identifier the GPLv2 statement becomes redundant and we can remove some lines. Andi