Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752586AbdLLPd6 (ORCPT ); Tue, 12 Dec 2017 10:33:58 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:46880 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752160AbdLLPdy (ORCPT ); Tue, 12 Dec 2017 10:33:54 -0500 X-Google-Smtp-Source: ACJfBot+L/kunaEdTtPmWjhNxEs+YUJxxHvfkLLORb2In6mzRdoLDz8H1HByehQZPfXd3gEb3irIEuVcTD00CVYIek4= MIME-Version: 1.0 In-Reply-To: <20171212151102.18672-1-hdegoede@redhat.com> References: <20171212151102.18672-1-hdegoede@redhat.com> From: Philippe Ombredanne Date: Tue, 12 Dec 2017 16:33:12 +0100 Message-ID: Subject: Re: [PATCH] platform/x86: Add driver for GPD pocket custom fan controller To: Hans de Goede Cc: Darren Hart , Andy Shevchenko , platform-driver-x86@vger.kernel.org, LKML , James Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 958 Lines: 34 Dear Hans, On Tue, Dec 12, 2017 at 4:11 PM, Hans de Goede wrote: > Add a driver for the GPD pocket device's custom fan controller, which > gets controlled through 2 GPIOs listed in a FAN02501 ACPI device. [...] > --- /dev/null > +++ b/drivers/platform/x86/gpd-pocket-fan.c > @@ -0,0 +1,193 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ This should be IMHO this style as requested by Linus on list and documented by Thomas in the doc patches: // SPDX-License-Identifier: GPL-2.0 > +MODULE_LICENSE("GPL"); This module license means "GPL 2 or later" and does not match your top level GPL 2.0 license tag and should be instead as per module.h doc: MODULE_LICENSE("GPL v2"); .... unless you want this to be GPL 2.0 or later all the way in which case it should be: // SPDX-License-Identifier: GPL-2.0+ and MODULE_LICENSE("GPL"); ... though I am not sure what is the point of "or later" for a module. -- Cordially Philippe Ombredanne