Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752368AbdLLQFC (ORCPT ); Tue, 12 Dec 2017 11:05:02 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:35534 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751643AbdLLQE7 (ORCPT ); Tue, 12 Dec 2017 11:04:59 -0500 X-Google-Smtp-Source: ACJfBotJx/3yymfjMJVmOdPEOYAL/ewrMILkZEG2OhrRjjONP/s+hfPNSWNKw4sRGas2vQQs5xiYwQ== Subject: Re: [PATCH] Revert "dt-bindings: mtd: add sst25wf040b and en25s64 to sip-nor list" To: Cyrille Pitchen , linux-mtd@lists.infradead.org Cc: computersforpeace@gmail.com, dwmw2@infradead.org, boris.brezillon@free-electrons.com, richard@nod.at, linux-kernel@vger.kernel.org, Zhiqiang.Hou@nxp.com, shawnguo@kernel.org, robh@kernel.org References: <20171212134012.19949-1-cyrille.pitchen@wedev4u.fr> From: Marek Vasut Message-ID: Date: Tue, 12 Dec 2017 16:58:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171212134012.19949-1-cyrille.pitchen@wedev4u.fr> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1794 Lines: 51 On 12/12/2017 02:40 PM, Cyrille Pitchen wrote: > This reverts commit b07815d4eaf658b683c345d6e643895a20d92f29. > > The reverted commit was merged into v4-15-rc1 by mistake: it was taken > from the IMX tree but the patch has never been sent to linux-mtd nor > reviewed by any spi-nor maintainers. > > Actually, it would have been rejected since we add new values for the > 'compatible' DT property only for SPI NOR memories that don't support > the JEDEC READ ID op code (0x9F). > > Both en25s64 and sst25wf040b support the JEDEC READ ID op code, hence > should use the "jedec,spi-nor" string alone as 'compatible' value. > > See the following link for more details: > http://lists.infradead.org/pipermail/linux-mtd/2017-November/077425.html > > Signed-off-by: Cyrille Pitchen Acked-by: Marek Vasut > --- > Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt > index 376fa2f50e6b..956bb046e599 100644 > --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt > +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt > @@ -13,7 +13,6 @@ Required properties: > at25df321a > at25df641 > at26df081a > - en25s64 > mr25h128 > mr25h256 > mr25h10 > @@ -33,7 +32,6 @@ Required properties: > s25fl008k > s25fl064k > sst25vf040b > - sst25wf040b > m25p40 > m25p80 > m25p16 > -- Best regards, Marek Vasut