Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752512AbdLLQbG (ORCPT ); Tue, 12 Dec 2017 11:31:06 -0500 Received: from mail-qt0-f180.google.com ([209.85.216.180]:37089 "EHLO mail-qt0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752204AbdLLQbD (ORCPT ); Tue, 12 Dec 2017 11:31:03 -0500 X-Google-Smtp-Source: ACJfBotLykeMsgP2tT5sofW4lsve3XgYvyOmQebe7oGUPn87nDCp4DcbXa1IGUqqWGD0+YoMl8xo3w== Date: Tue, 12 Dec 2017 08:30:59 -0800 From: Tejun Heo To: xuejiufei Cc: Jens Axboe , Jan Kara , cgroups@vger.kernel.org, kernel-team@fb.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] writeback: synchronize sync(2) against cgroup writeback membership switches Message-ID: <20171212163059.GB3919388@devbig577.frc2.facebook.com> References: <20171205182007.GV2421075@devbig577.frc2.facebook.com> <8844b550-d91c-38d5-997a-a899d1e4aa42@gmail.com> <20171211195052.GN2421075@devbig577.frc2.facebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 252 Lines: 13 Hello, On Tue, Dec 12, 2017 at 02:04:45PM +0800, xuejiufei wrote: > The initialization of wb_switch_rwsem should be in > the conditional compilation of CONFIG_CGROUP_WRITEBACK, > right? Oops, you're right. Will update the patch. Thanks. -- tejun