Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752434AbdLLQj1 (ORCPT ); Tue, 12 Dec 2017 11:39:27 -0500 Received: from mail-wm0-f52.google.com ([74.125.82.52]:42002 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752048AbdLLQjW (ORCPT ); Tue, 12 Dec 2017 11:39:22 -0500 X-Google-Smtp-Source: ACJfBovwfyGLxv3v8UFMJnsGUbuoJtc0HcrpBM6KT2GPvKEoiGZqfJZtrsoG3hVxVxVUi5Wy6YBDZA== Subject: Re: [PATCH] platform/x86: Add driver for GPD pocket custom fan controller To: Philippe Ombredanne Cc: Darren Hart , Andy Shevchenko , platform-driver-x86@vger.kernel.org, LKML , James References: <20171212151102.18672-1-hdegoede@redhat.com> From: Hans de Goede Message-ID: <7e78fc7d-b837-6b8c-55cc-799cca9b9fc2@redhat.com> Date: Tue, 12 Dec 2017 17:39:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1234 Lines: 45 Hi, On 12-12-17 16:33, Philippe Ombredanne wrote: > Dear Hans, > > On Tue, Dec 12, 2017 at 4:11 PM, Hans de Goede wrote: >> Add a driver for the GPD pocket device's custom fan controller, which >> gets controlled through 2 GPIOs listed in a FAN02501 ACPI device. > [...] > >> --- /dev/null >> +++ b/drivers/platform/x86/gpd-pocket-fan.c >> @@ -0,0 +1,193 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ > > This should be IMHO this style as requested by Linus on list and > documented by Thomas in the doc patches: > // SPDX-License-Identifier: GPL-2.0 Ok, fixed for v2. >> +MODULE_LICENSE("GPL"); > > This module license means "GPL 2 or later" and does not match your top > level GPL 2.0 license tag and should be instead as per module.h doc: > MODULE_LICENSE("GPL v2"); > > .... unless you want this to be GPL 2.0 or later all the way in which > case it should be: > // SPDX-License-Identifier: GPL-2.0+ > and > MODULE_LICENSE("GPL"); > > ... though I am not sure what is the point of "or later" for a module. I prefer for "v2 or later" just in case there ever is a GPL v4 which is more sensible then v3... So I've changed the SPDX identifier to: // SPDX-License-Identifier: GPL-2.0+ Regards, Hans