MIME-Version: 1.0
In-Reply-To: <20171212164738.31463-1-daniel.thompson@linaro.org>
References: <20171212164738.31463-1-daniel.thompson@linaro.org>
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date: Tue, 12 Dec 2017 16:54:14 +0000
Message-ID: <CAKv+Gu-khhu4bCEi=dGgXDsF7ptH_5ufkeR_mi6YpiCvSxhHmw@mail.gmail.com>
Subject: Re: [PATCH] usb: xhci: Add XHCI_TRUST_TX_LENGTH for Renesas uPD720201
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
        linux-usb <linux-usb@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Patch Tracking <patches@linaro.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1519
Lines: 40

On 12 December 2017 at 16:47, Daniel Thompson
<daniel.thompson@linaro.org> wrote:
> When plugging in a USB webcam I see the following message:
> xhci_hcd 0000:04:00.0: WARN Successful completion on short TX: needs
> XHCI_TRUST_TX_LENGTH quirk?
> handle_tx_event: 913 callbacks suppressed
>
> All is quiet again with this patch (and I've done a fair but of soak
> testing with the camera since).
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>

I have been setting this quirk manually for ages on my kernel command
line, for the same reason (MS HD Webcam), and with the same positive
result, so

Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  drivers/usb/host/xhci-pci.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index 7ef1274ef7f7..1aad89b8aba0 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -177,6 +177,9 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
>                 xhci->quirks |= XHCI_TRUST_TX_LENGTH;
>                 xhci->quirks |= XHCI_BROKEN_STREAMS;
>         }
> +       if (pdev->vendor == PCI_VENDOR_ID_RENESAS &&
> +                       pdev->device == 0x0014)
> +               xhci->quirks |= XHCI_TRUST_TX_LENGTH;
>         if (pdev->vendor == PCI_VENDOR_ID_RENESAS &&
>                         pdev->device == 0x0015)
>                 xhci->quirks |= XHCI_RESET_ON_RESUME;
> --
> 2.14.2
>