Subject: Re: [PATCH 0/8] make some functions return bool
To: baiyaowei@cmss.chinamobile.com, David Rientjes <rientjes@google.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
References: <1513047319-22302-1-git-send-email-baiyaowei@cmss.chinamobile.com>
 <alpine.DEB.2.10.1712112149010.56473@chino.kir.corp.google.com>
 <20171212072130.GA12496@byw>
From: Randy Dunlap <rdunlap@infradead.org>
Message-ID: <0c71240b-ae6a-1233-3a59-e93081232823@infradead.org>
Date: Tue, 12 Dec 2017 09:20:56 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <20171212072130.GA12496@byw>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 932
Lines: 25

On 12/11/2017 11:21 PM, Yaowei Bai wrote:
> On Mon, Dec 11, 2017 at 09:50:03PM -0800, David Rientjes wrote:
>> On Mon, 11 Dec 2017, Yaowei Bai wrote:
>>
>>> This patchset makes some *_is_* like functions return bool because
>>> these functions only use true or false as their return values.
>>>
>>> No functional changes.

I agree with the idea that predicate-like functions are boolean functions
and should return bool.  Whether you can get someone to merge the patches
is a different subject.

>> I think the concern about this type of patchset in the past is that it is 
>> unnecessary churn and makes it more time consuming to research git history 
>> without any significant improvement.
> 
> While, relative to a modern computer with superb computional power, i
> think the additional time to search git history is negligable and this
> type of patchset is also a good practice for the kernel beginner guys.
> :)


-- 
~Randy