Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752265AbdLLSnD (ORCPT ); Tue, 12 Dec 2017 13:43:03 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:38488 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751554AbdLLSnB (ORCPT ); Tue, 12 Dec 2017 13:43:01 -0500 Subject: Re: [PATCH] KVM: introduce kvm_arch_vcpu_async_ioctl To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: kvm-ppc@vger.kernel.org, cohuck@redhat.com, christoffer.dall@linaro.org, James Hogan , Paul Mackerras References: <1513099915-107126-1-git-send-email-pbonzini@redhat.com> From: Christian Borntraeger Date: Tue, 12 Dec 2017 19:42:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1513099915-107126-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17121218-0016-0000-0000-0000050C4BED X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17121218-0017-0000-0000-000028485FA9 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-12_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1712120265 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1026 Lines: 26 On 12/12/2017 06:31 PM, Paolo Bonzini wrote: > After the vcpu_load/vcpu_put pushdown, the handling of asynchronous VCPU > ioctl is already much clearer in that it is obvious that they bypass > vcpu_load and vcpu_put. > > However, it is still not perfect in that the different state of the VCPU > mutex is still hidden in the caller. Separate those ioctls into a new > function kvm_arch_vcpu_async_ioctl that returns -ENOIOCTLCMD for more > "traditional" synchronous ioctls. > > Cc: James Hogan > Cc: Paul Mackerras > Cc: Christian Borntraeger looks sane. > Suggested-by: Cornelia Huck > Signed-off-by: Paolo Bonzini > --- > arch/mips/kvm/mips.c | 15 ++++++++++++--- > arch/powerpc/kvm/powerpc.c | 14 +++++++++++--- > arch/s390/kvm/kvm-s390.c | 16 ++++++++++++---- > include/linux/kvm_host.h | 2 ++ > virt/kvm/kvm_main.c | 8 ++++---- > 5 files changed, 41 insertions(+), 14 deletions(-) >