Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752712AbdLLWWO (ORCPT ); Tue, 12 Dec 2017 17:22:14 -0500 Received: from mail-qt0-f171.google.com ([209.85.216.171]:35140 "EHLO mail-qt0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752320AbdLLWWM (ORCPT ); Tue, 12 Dec 2017 17:22:12 -0500 X-Google-Smtp-Source: ACJfBou1NrwSXKjYAq1E4OliEY0/+ocsHkpKVzaqIMnncITbQg5agCp4c/ppdpkH/5S5kbMMqZWKaA== Date: Tue, 12 Dec 2017 14:22:04 -0800 From: "tj@kernel.org" To: Bart Van Assche Cc: "axboe@kernel.dk" , "kernel-team@fb.com" , "linux-kernel@vger.kernel.org" , "peterz@infradead.org" , "osandov@fb.com" , "linux-block@vger.kernel.org" , "oleg@redhat.com" , "hch@lst.de" Subject: Re: [PATCH 6/6] blk-mq: remove REQ_ATOM_STARTED Message-ID: <20171212222204.GM3919388@devbig577.frc2.facebook.com> References: <20171212190134.535941-1-tj@kernel.org> <20171212190134.535941-7-tj@kernel.org> <1513117238.2999.54.camel@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1513117238.2999.54.camel@wdc.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 578 Lines: 14 On Tue, Dec 12, 2017 at 10:20:39PM +0000, Bart Van Assche wrote: > The above code should show all requests owned by the block driver. Patch > "blk-mq-debugfs: Also show requests that have not yet been started" (not yet > in Jens' tree) changes the REQ_ATOM_STARTED test into list_empty(&rq->queuelist). > Can that change be supported with the existing MQ_RQ_* states or will a new > state have to be introduced to support this? See also > https://marc.info/?l=linux-block&m=151252188411991. If list_empty() test was correct before, it'd be correct now too. Thnaks. -- tejun