Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752737AbdLLWlb (ORCPT ); Tue, 12 Dec 2017 17:41:31 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:39037 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752654AbdLLWl3 (ORCPT ); Tue, 12 Dec 2017 17:41:29 -0500 X-Google-Smtp-Source: ACJfBou+q7iTL59bjD0g5i2poroZ5ao8gD8N9+pWvASebJdrDJKe8rw/4unUihylw+JNr+jRq0e6jjurxDI9QS9YE2A= MIME-Version: 1.0 In-Reply-To: <20171212175205.236-4-salil.mehta@huawei.com> References: <20171212175205.236-1-salil.mehta@huawei.com> <20171212175205.236-4-salil.mehta@huawei.com> From: Philippe Ombredanne Date: Tue, 12 Dec 2017 23:40:47 +0100 Message-ID: Subject: Re: [PATCH V3 net-next 3/8] net: hns3: Add HNS3 VF HCL(Hardware Compatibility Layer) Support To: Salil Mehta Cc: "David S. Miller" , yisen.zhuang@huawei.com, lipeng321@huawei.com, Salil Mehta , netdev@vger.kernel.org, LKML , linux-rdma@vger.kernel.org, linuxarm@huawei.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2164 Lines: 56 Dear Salil, On Tue, Dec 12, 2017 at 6:52 PM, Salil Mehta wrote: > This patch adds the support of hardware compatibiltiy layer to the > HNS3 VF Driver. This layer implements various {set|get} operations > over MAC address for a virtual port, RSS related configuration, > fetches the link status info from PF, does various VLAN related > configuration over the virtual port, queries the statistics from > the hardware etc. > > This layer can directly interact with hardware through the > IMP(Integrated Mangement Processor) interface or can use mailbox > to interact with the PF driver. > > Signed-off-by: Salil Mehta > Signed-off-by: lipeng > --- > Patch V3: Addressed SPDX change requested by Philippe Ombredanne > Link: https://lkml.org/lkml/2017/12/8/874 > Patch V2: Addressed some internal comments > Patch V1: Initial Submit > --- > .../ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 1490 ++++++++++++++++++++ > .../ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h | 164 +++ > 2 files changed, 1654 insertions(+) > create mode 100644 drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c > create mode 100644 drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h > > diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c > new file mode 100644 > index 0000000..ff55f4c > --- /dev/null > +++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c > @@ -0,0 +1,1490 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright (c) 2016-2017 Hisilicon Limited. > + */ This is just me nitpicking and this is entirely up to you.... but in such a simple case you could go all the way too: > +// SPDX-License-Identifier: GPL-2.0+ > +// Copyright (c) 2016-2017 Hisilicon Limited. In this case this can make the thing look more consistent. See also Linus commentaries about this [1][2][3][4] [1] https://lkml.org/lkml/2017/11/25/133 [2] https://lkml.org/lkml/2017/11/25/125 [3] https://lkml.org/lkml/2017/11/2/715 [4] https://lkml.org/lkml/2017/11/2/805 -- Cordially Philippe Ombredanne