Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752275AbdLMBwT (ORCPT ); Tue, 12 Dec 2017 20:52:19 -0500 Received: from cmccmta2.chinamobile.com ([221.176.66.80]:51441 "EHLO cmccmta2.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751622AbdLMBwR (ORCPT ); Tue, 12 Dec 2017 20:52:17 -0500 X-RM-TRANSID: 2ee55a3087cbb39-f871b X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 X-RM-TRANSID: 2eea5a3087c9514-20d8e Date: Tue, 12 Dec 2017 20:52:04 -0500 From: Yaowei Bai To: Ilya Dryomov Cc: "Yan, Zheng" , Sage Weil , Ceph Development , linux-kernel@vger.kernel.org Subject: Re: [PATCH] fs/ceph: delete unused ceph_file_layout_is_valid function Message-ID: <20171213015204.GA28668@byw> Reply-To: baiyaowei@cmss.chinamobile.com References: <1513043801-9164-1-git-send-email-baiyaowei@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 518 Lines: 16 On Tue, Dec 12, 2017 at 11:15:05AM +0100, Ilya Dryomov wrote: > On Tue, Dec 12, 2017 at 2:56 AM, Yaowei Bai > wrote: > > There's no users of ceph_file_layout_is_valid, remove it. > > It'll get a user in the next kernel release -- we'll remove ad-hoc > checks from ceph_calc_file_object_mapping() which is executed on every > mapping and call ceph_file_layout_is_valid() once per layout instead. Maybe we can re-add it when it's used indeed. > > Thanks, > > Ilya