Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753547AbdLMCci (ORCPT ); Tue, 12 Dec 2017 21:32:38 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:49315 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753445AbdLMCcd (ORCPT ); Tue, 12 Dec 2017 21:32:33 -0500 Subject: Re: [PATCH 0/8] make some functions return bool To: baiyaowei@cmss.chinamobile.com Cc: David Rientjes , akpm@linux-foundation.org, linux-kernel@vger.kernel.org References: <1513047319-22302-1-git-send-email-baiyaowei@cmss.chinamobile.com> <20171212072130.GA12496@byw> <0c71240b-ae6a-1233-3a59-e93081232823@infradead.org> <20171213021427.GB28668@byw> From: Randy Dunlap Message-ID: <81cc7b9e-8d3d-d529-7459-1d8a1e3baa65@infradead.org> Date: Tue, 12 Dec 2017 18:32:32 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171213021427.GB28668@byw> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1500 Lines: 46 On 12/12/2017 06:14 PM, Yaowei Bai wrote: > On Tue, Dec 12, 2017 at 09:20:56AM -0800, Randy Dunlap wrote: >> On 12/11/2017 11:21 PM, Yaowei Bai wrote: >>> On Mon, Dec 11, 2017 at 09:50:03PM -0800, David Rientjes wrote: >>>> On Mon, 11 Dec 2017, Yaowei Bai wrote: >>>> >>>>> This patchset makes some *_is_* like functions return bool because >>>>> these functions only use true or false as their return values. >>>>> >>>>> No functional changes. >> >> I agree with the idea that predicate-like functions are boolean functions >> and should return bool. > > Then you can use Acked-by to support me. :) Sure, but I didn't keep the patch emails. Acked-by: Randy Dunlap >> Whether you can get someone to merge the patches is a different subject. > > The kernel development is not just developing hard codes. The talented > guys develop new features and bugfixes, while the other ones do cleanups > for them. These two parts of work are all welcome and should be > accepted by our community. > >> >>>> I think the concern about this type of patchset in the past is that it is >>>> unnecessary churn and makes it more time consuming to research git history >>>> without any significant improvement. >>> >>> While, relative to a modern computer with superb computional power, i >>> think the additional time to search git history is negligable and this >>> type of patchset is also a good practice for the kernel beginner guys. >>> :) >> >> >> -- >> ~Randy -- ~Randy